Right now they have `koha:koha` hardcoded.
Created attachment 190116 [details] [review] Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Created attachment 190144 [details] [review] Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Just noting that these Cypress tests were failing for me, with everything up-to-date (before the patches were applied): - t/cypress/integration/Preservation/Settings.ts: fixed by Bug 41364 - Error in preservation module breadcrumb - t/cypress/integration/SIP2/Accounts.ts (couldn't find a bug) - t/cypress/integration/Tools/ManageMarcImport_spec.ts: fixed by Bug 41368 - Tools/ManageMarcImport_spec.ts is failing - t/cypress/integrations/t/api-client.ts (couldn't find a bug)
You are fixing only half of the problem, you also need bug 40446.
Testing notes (using KTD): 1. Just noting that these Cypress tests were failing for me, with everything up-to-date (before the patches were applied): - t/cypress/integration/Preservation/Settings.ts: fixed by Bug 41364 - Error in preservation module breadcrumb - t/cypress/integration/SIP2/Accounts.ts (originally failed, but now passing) - t/cypress/integration/Tools/ManageMarcImport_spec.ts: fixed by Bug 41368 - Tools/ManageMarcImport_spec.ts is failing - t/cypress/integration/t/api-client.ts (couldn't find a bug) (Updated with correct path, and that Accounts.ts is now passing.)