Bug 41456 - Item type filter on the hold history view does not work correctly
Summary: Item type filter on the hold history view does not work correctly
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 41451
Blocks: 41457
  Show dependency treegraph
 
Reported: 2025-12-16 12:29 UTC by Jonathan Druart
Modified: 2025-12-16 16:35 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the patron's holds history table in the staff interface. The search filter now works as expected - using the library name or library code and requested item type name or item type code (when AllowHoldItemTypeSelection is enabled) now work as expected, and the column filters for both of these now use dropdown lists.
Version(s) released in:
Circulation function:


Attachments
Bug 41456: Fix item type searching and filtering on the holds history table (10.46 KB, patch)
2025-12-16 12:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41456: Fix item type searching and filtering on the holds history table (10.50 KB, patch)
2025-12-16 16:27 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-12-16 12:29:44 UTC
We should be able to search using the item type's code or description. We also need to have the item types listed in a dropdown list.
Comment 1 Jonathan Druart 2025-12-16 12:43:01 UTC
Created attachment 190537 [details] [review]
Bug 41456: Fix item type searching and filtering on the holds history table

Use should use coded_values for the library and item type column so that
we can search using the code and the description.

With this patch we now have a dropdown list with the libraries and item
types in the table's headers.

Test plan:
0. Turn on AllowHoldItemTypeSelection
1. Create a hold and select an item type
Note: I think there is a bug if you select it from "Hold next available
item", use "Hold details". Please confirm?
2. Go to the holds history view
3. Filter and search by item type description and code. Same for
   library.
   Use the dropdown list in the headers.
Comment 2 David Nind 2025-12-16 16:27:54 UTC
Created attachment 190553 [details] [review]
Bug 41456: Fix item type searching and filtering on the holds history table

Use should use coded_values for the library and item type column so that
we can search using the code and the description.

With this patch we now have a dropdown list with the libraries and item
types in the table's headers.

Test plan:
0. Turn on AllowHoldItemTypeSelection
1. Create a hold and select an item type
Note: I think there is a bug if you select it from "Hold next available
item", use "Hold details". Please confirm?
2. Go to the holds history view
3. Filter and search by item type description and code. Same for
   library.
   Use the dropdown list in the headers.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-12-16 16:30:00 UTC
For step 1, if I select "Request specific item type" (Books):

- from under the "Hold next available item" section, it shows in the patron's holds history as "Any item type" (doesn't matter what I select here)

- from under "Hold details" section, it shows in the patron's holds history as "Book"