Mysql does not allow blob or text type columns to have a default. The systempreferences.value column is the only occurrence of this I found in the kohastructure.sql file. It seems Mysql will ignore the default null as long as the column allows null, so that's not an issue. Bug 40405 sets systempreferences.value to NOT NULL, but tries to also add a DEFAULT '', which causes Mysql to throw the above error. Proposed solution is to remove the DEFAULT '' part of the clause from the db_rev file.
Created attachment 190558 [details] [review] Bug 41460: Remove default value from mediumtext column systempreferences.value Bug 41460: Remove default value from mediumtext column systempreferences.value Mysql doesn't allow text type columns to have a default. I think this is a trivial patch.
Any hints on how to test this using KTD?
MySQL 8 ?
Then you need to adjust this one: installer/data/mysql/kohastructure.sql 6680 `value` mediumtext NOT NULL DEFAULT '' COMMENT 'system preference values',
Created attachment 190960 [details] [review] Bug 41460: Remove default value from mediumtext column systempreferences.value Mysql doesn't allow text type columns to have a default.
I think you need to add an atomic update for main as well, and that will then allow people to test "main' as well.
Created attachment 191330 [details] [review] Bug 41460: Remove default value from mediumtext column systempreferences.value Mysql doesn't allow text type columns to have a default.
Happy to test, but don't know enough about how to test this without a test plan. Have added a related bug that deals with other system preference related issues.