Created attachment 190569 [details] [review] Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected.
Created attachment 190570 [details] [review] Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected.
Created attachment 190592 [details] [review] Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net>
Created attachment 192165 [details] [review] Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net>
Works great, I'd love if the type on this page and the table for authenticated users matched the display in the dropdown, but I think that's outside the scope of this bug. I'll file (or find) a seperate bug for that.
Created attachment 192166 [details] [review] Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Nice work everyone! Pushed to main for 26.05