Bug 41465 - Unauthenticated request does not display 'type' correctly
Summary: Unauthenticated request does not display 'type' correctly
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2025-12-17 12:02 UTC by Pedro Amorim
Modified: 2025-12-17 17:04 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41465: Fix display of 'type' for unauthenticated ILL request (2.05 KB, patch)
2025-12-17 12:03 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41465: Fix display of 'type' for unauthenticated ILL request (2.12 KB, patch)
2025-12-17 12:05 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41465: Fix display of 'type' for unauthenticated ILL request (2.17 KB, patch)
2025-12-17 17:03 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-12-17 12:02:03 UTC

    
Comment 1 Pedro Amorim 2025-12-17 12:03:38 UTC
Created attachment 190569 [details] [review]
Bug 41465: Fix display of 'type' for unauthenticated ILL request

'request' is unblessed in this context. get_type doesnt exist/work.

Test plan:
1) Enable ILLModule and ILLOpacUnauthenticatedRequest
2) Logout, place an OPAC unauthenticated ILL request, visit:
3) Input all mandatory fields. Click 'Create'.
4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick.
5) Apply patch. Repeat. Notice 'Request type' now shows as expected.
Comment 2 Pedro Amorim 2025-12-17 12:05:34 UTC
Created attachment 190570 [details] [review]
Bug 41465: Fix display of 'type' for unauthenticated ILL request

'request' is unblessed in this context. get_type doesnt exist/work.

Test plan:
1) Enable ILLModule and ILLOpacUnauthenticatedRequest
2) Logout, place an OPAC unauthenticated ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form
3) Input all mandatory fields. Click 'Create'.
4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick.
5) Apply patch. Repeat. Notice 'Request type' now shows as expected.
Comment 3 OpenFifth Sandboxes 2025-12-17 17:03:29 UTC
Created attachment 190592 [details] [review]
Bug 41465: Fix display of 'type' for unauthenticated ILL request

'request' is unblessed in this context. get_type doesnt exist/work.

Test plan:
1) Enable ILLModule and ILLOpacUnauthenticatedRequest
2) Logout, place an OPAC unauthenticated ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form
3) Input all mandatory fields. Click 'Create'.
4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick.
5) Apply patch. Repeat. Notice 'Request type' now shows as expected.

Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net>