Bug 41467 - When transfer not allowed the 'Originating branch' is not populated
Summary: When transfer not allowed the 'Originating branch' is not populated
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-17 14:06 UTC by Nick Clemens (kidclamp)
Modified: 2025-12-20 12:44 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41467: Return from branch for transfer NotAllowed (2.77 KB, patch)
2025-12-17 14:09 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41467: Return from branch for transfer NotAllowed (2.82 KB, patch)
2025-12-20 12:44 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-12-17 14:06:59 UTC
To recreate:
1 - SET syspref UseBranchTransferLimits/BranchTransferLimitsType
    To Enfore based on collection
2 - Administration->Library Transfer limits click (Advanced editor)
3 - Uncheck Centerville->Fairfield for 'Fiction'
4 - Find or create a Fiction item at centerville
5 - Circulation->Transfer
6 - Attempt to transfer item to Fairfield
7 - Note 'Originating library' is blank
Comment 1 Nick Clemens (kidclamp) 2025-12-17 14:09:15 UTC
Created attachment 190583 [details] [review]
Bug 41467: Return from branch for transfer NotAllowed

This patch adds the from branch to the returned error and simplifies
the logic of the test

We have effective_itemtype so don't need a conditional based on item type level

To test:
 1 - SET syspref UseBranchTransferLimits/BranchTransferLimitsType
    To Enfore based on collection
 2 - Administration->Library Transfer limits click (Advanced editor)
 3 - Uncheck Centerville->Fairfield for 'Fiction'
 4 - Find or create a Fiction item at centerville
 5 - Circulation->Transfer
 6 - Attempt to transfer item to Fairfield
 7 - Note 'Originating library' is blank
 8 - Apply patch
 9 - Restart all
10 - Attempt transfer again
11 - Error is fully populated
Comment 2 Roman Dolny 2025-12-20 12:44:50 UTC
Created attachment 190653 [details] [review]
Bug 41467: Return from branch for transfer NotAllowed

This patch adds the from branch to the returned error and simplifies
the logic of the test

We have effective_itemtype so don't need a conditional based on item type level

To test:
 1 - SET syspref UseBranchTransferLimits/BranchTransferLimitsType
    To Enfore based on collection
 2 - Administration->Library Transfer limits click (Advanced editor)
 3 - Uncheck Centerville->Fairfield for 'Fiction'
 4 - Find or create a Fiction item at centerville
 5 - Circulation->Transfer
 6 - Attempt to transfer item to Fairfield
 7 - Note 'Originating library' is blank
 8 - Apply patch
 9 - Restart all
10 - Attempt transfer again
11 - Error is fully populated

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>