Bug 41557 - LoginFirstname, LoginSurname and emailaddress sent to template but never used
Summary: LoginFirstname, LoginSurname and emailaddress sent to template but never used
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: 22264cc
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2026-01-09 09:25 UTC by Jonathan Druart
Modified: 2026-01-23 14:30 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41557: Remove unused vars sent to template (1.74 KB, patch)
2026-01-09 09:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41557: Remove unused vars sent to template (1.79 KB, patch)
2026-01-21 21:03 UTC, 22264cc
Details | Diff | Splinter Review
Bug 41557: Remove unused vars sent to template (1.86 KB, patch)
2026-01-21 21:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 09:25:59 UTC
Bel Inconnu is actually no longer used

 488         LoginFirstname               => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ),
 489         LoginSurname                 => C4::Context->userenv ? C4::Context->userenv->{"surname"}      : "Inconnu",
 490         emailaddress                 => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef,
Comment 1 Jonathan Druart 2026-01-09 09:27:37 UTC
Created attachment 191047 [details] [review]
Bug 41557: Remove unused vars sent to template

 488         LoginFirstname               => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ),
 489         LoginSurname                 => C4::Context->userenv ? C4::Context->userenv->{"surname"}      : "Inconnu",
 490         emailaddress                 => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef,

Test plan:
`git grep` the 3 variables and confirm that there is no occurrences in
the templates (.tt/.inc files)
Comment 2 22264cc 2026-01-21 21:03:32 UTC
Created attachment 191829 [details] [review]
Bug 41557: Remove unused vars sent to template

488         LoginFirstname               => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ),
 489         LoginSurname                 => C4::Context->userenv ? C4::Context->userenv->{"surname"}      : "Inconnu",
 490         emailaddress                 => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef,

Test plan:
`git grep` the 3 variables and confirm that there is no occurrences in
the templates (.tt/.inc files)

Signed-off-by: Connor Cameron-Jones <22264cc@hvhs.school.nz>
Comment 3 Katrin Fischer 2026-01-21 21:23:27 UTC
Created attachment 191839 [details] [review]
Bug 41557: Remove unused vars sent to template

488         LoginFirstname               => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ),
 489         LoginSurname                 => C4::Context->userenv ? C4::Context->userenv->{"surname"}      : "Inconnu",
 490         emailaddress                 => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef,

Test plan:
`git grep` the 3 variables and confirm that there is no occurrences in
the templates (.tt/.inc files)

Signed-off-by: Connor Cameron-Jones <22264cc@hvhs.school.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Lucas Gass (lukeg) 2026-01-23 14:30:20 UTC
Nice work everyone!

Pushed to main for 26.05