Bug 41570 - Tidy kohaTable block - course_reserves
Summary: Tidy kohaTable block - course_reserves
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 41324
  Show dependency treegraph
 
Reported: 2026-01-09 13:58 UTC by Jonathan Druart
Modified: 2026-01-13 19:43 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41570: Tidy kohaTable - course_reserves/course-details.tt (2.37 KB, patch)
2026-01-09 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt (1.08 KB, patch)
2026-01-09 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41570: course_reserves - auto tidy (3.55 KB, patch)
2026-01-09 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41570: Tidy kohaTable - course_reserves/course-details.tt (2.42 KB, patch)
2026-01-13 19:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt (1.12 KB, patch)
2026-01-13 19:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41570: course_reserves - auto tidy (3.60 KB, patch)
2026-01-13 19:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41570: (follow-up) i18n correction, course deletion fix (3.69 KB, patch)
2026-01-13 19:43 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 13:58:05 UTC

    
Comment 1 Jonathan Druart 2026-01-09 14:48:10 UTC
Created attachment 191127 [details] [review]
Bug 41570: Tidy kohaTable - course_reserves/course-details.tt

Patch from commit 78c174e
Comment 2 Jonathan Druart 2026-01-09 14:48:11 UTC
Created attachment 191128 [details] [review]
Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt

Patch from commit 4cb6d9d
Comment 3 Jonathan Druart 2026-01-09 14:48:12 UTC
Created attachment 191129 [details] [review]
Bug 41570: course_reserves - auto tidy

Patch from commit 8f0d9c9
Comment 4 Owen Leonard 2026-01-13 19:43:42 UTC
Created attachment 191389 [details] [review]
Bug 41570: Tidy kohaTable - course_reserves/course-details.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2026-01-13 19:43:45 UTC
Created attachment 191390 [details] [review]
Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2026-01-13 19:43:48 UTC
Created attachment 191391 [details] [review]
Bug 41570: course_reserves - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2026-01-13 19:43:51 UTC
Created attachment 191392 [details] [review]
Bug 41570: (follow-up) i18n correction, course deletion fix

The template's i18n function, I18N.tnx, doesn't work with JavaScript
variables, so I've updated it to use the template variable.

I also found that I couldn't properly test the course deletion function
without fixing a problem which exists in main: The delete course button
didn't trigger the confirmation, and the event which was supposed to
trigger the confirmation was attached to the whole form.

The confirmation is now triggered on form submit.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>