Bug 36433 introduced a plugin hook for elasticsearch document generation, which makes the `authority_hooks.t` print some useless noise when ES is enabled in the context: ```shell prove t/db_dependent/Koha/Plugins/t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ```
Created attachment 191434 [details] [review] Bug 41616: Silence warning in authority_hooks.t This patch silences a useless warning that is printed when in ES context. To test: 1. Launch a KTD instance with ES enabled: $ ktd --proxy --name 41616 --search-engine es8 up -d $ ktd --name 41616 --wait-ready 120 2. Run: $ ktd --name 41616 --shell k$ prove t/db_dependent/Koha/Plugins/authority_hooks.t => SUCCESS: Tests pass => FAIL: You see: ```shell prove t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: No tests changes, but no more weird warnings about elasticsearch 5. Sign off :-D 6. Cleanup: $ ktd --name 41616 down Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Created attachment 191550 [details] [review] Bug 41616: Silence warning in authority_hooks.t This patch silences a useless warning that is printed when in ES context. To test: 1. Launch a KTD instance with ES enabled: $ ktd --proxy --name 41616 --search-engine es8 up -d $ ktd --name 41616 --wait-ready 120 2. Run: $ ktd --name 41616 --shell k$ prove t/db_dependent/Koha/Plugins/authority_hooks.t => SUCCESS: Tests pass => FAIL: You see: ```shell prove t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: No tests changes, but no more weird warnings about elasticsearch 5. Sign off :-D 6. Cleanup: $ ktd --name 41616 down Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>