Bug 4171 - overduerules.pl needs an overhaul
Summary: overduerules.pl needs an overhaul
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Nighswonger
QA Contact: Bugs List
Depends on:
Blocks: 13742
  Show dependency treegraph
Reported: 2010-02-12 02:07 UTC by Chris Nighswonger
Modified: 2020-01-06 20:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:23:58 UTC

---- Reported by cnighswonger@foundations.edu 2010-02-12 14:07:38 ----

<kf> ah ok, there are some other bad things about notice triggers
<kf> minimal value is 1
<kf> and dont use the default library - no notices will be sent
<chris_n> kf: so the script does not process any notices with a delay of less than 1?
<kf> got no notice when I tried with 0
<kf> only with 1 for the first notice
<kf> this is the day after due date
<kf> which is ok, because you can also sent itemdue and advances notices
<kf> but a hint would be good
<chris_n> kf: so if I want an advanced notice sent , it will not send until 1 day *after* the item is due?
<kf> overdue notices
<nengard> chris_n - you are missing the point - the advanced notice shouldn't be on that triggers page at all cause it's handled on the enhanced messaging preferences on the patron record
<kf> advances notices are sent before due date
<chris_n> nengard: big bug then :)
<chris_n> a blocker imho
<nengard> unless I too am misunderstanding
<kf> I dont understand the problem
<jwagner> I don't think it's a blocker, necessarily, but it definitely needs more explanatory text.  
<chris_n> kf: so if I set up an advanced notice do I have to set a delay?
* chris_n is confused as to whether the functionality is broken or just the documentation
<jwagner> chris_n, the delay is set in the patron record -- the Enhanced Messaging section.  You can do a global db update to set the same delay for everyone.
<kf> yes, or define the delay in patron type and import your new patrons after that :)
<jwagner> If you edit the patron categories and set up your desired settings there for advance notice, holds, etc., then any time you create a new patron it will pick up the settings automatically.  But there's no easy way short of a SQL update to modify existing records.
<chris_n> so then what is the Delay field for on the overduerules.pl page?
<kf> advanced notice = before due date and item due = due date are handled in advanced messaging, overdue notices in notice triggers
<nengard> chris_n - it should only be for overdue notices, but that's the part that needs fixing 
<nengard> right now you can pick it for anything
<jwagner> It's a documentation/screen display issue.
<kf> for overdue notices, days after due date
<jwagner> Ideally the notice triggers page should only filter/show overdue notices in the pulldowns.  If that's not possible, at least some screen text about "this is only for overdue notices"
<chris_n> so it sounds to me like the overduerules.pl page needs an overhaul
<kf> jwagner: right. but its nice you can create as many notice templates as you want and choose there
<jwagner> Right.  As I said, I'm not logged in right now so I can't look.  Is there anything in the settings that says "this notice is for overdues" as opposed to "this notice is for circ stuff"?  I don't remember.
<kf> perhaps a new option for notices - module overdue notices and show only those on notice triggers page
<kf> i think it shows all from circulation
<chris_n> I'm going to open two bugs then: one for the documentation and one for a general rework of overduerules.pl
<jwagner> Then yes, kf, making a new notice modules just for overdues & having the notice triggers only show those would work.
<kf> serials routing list and claim serial issues are already differnet modules, so its not really koha modules in this list

---- Additional Comments From nengard@gmail.com 2010-02-12 14:15:06 ----

i think that originally the advanced notice was going to be handled by those triggers, but then it was added to the patron enhanced messaging module

--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:23 UTC  ---

This bug was previously known as _bug_ 4171 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4171

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2013-01-15 14:20:25 UTC
I'm guessing this is still valid but this bug could really use a more succinct description of the problem if it is still a goal that it be fixed.
Comment 2 Katrin Fischer 2019-05-04 13:46:58 UTC
(In reply to Owen Leonard from comment #1)
> I'm guessing this is still valid but this bug could really use a more
> succinct description of the problem if it is still a goal that it be fixed.

As I was involved in the initial conversation and don't understand all of it and I know some related bugs exist, I am closing this WONTFIX for now.