Update PDF::Reuse to the current version 0.43. Update PDF::Reuse::Barcode to the current version 0.09 The existing test suite passes when with both so this should be a pretty straightforward bump. ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 perl -MPDF::Reuse -e "print \$PDF::Reuse::VERSION, chr(10)"' 0.43 ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 perl -MPDF::Reuse::Barcode -e "print \$PDF::Reuse::Barcode::VERSION, chr(10)"' 0.09 ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 bash -c "cd /kohadevbox/koha && prove t/Creators.t t/db_dependent/Labels/t_Label.t"' t/Creators.t ..................... ok t/db_dependent/Labels/t_Label.t .. ok All tests successful. Files=2, Tests=49, 4 wallclock secs ( 0.05 usr 0.01 sys + 3.46 cusr 0.38 csys = 3.90 CPU) Result: PASS
Created attachment 192075 [details] [review] Bug 41717: Bump PDF::Reuse and PDF::Reuse::Barcode versions PDF::Reuse 0.43 fixes a TTFont/docProxy lifecycle bug that caused prEnd() to crash when TrueType fonts were used. PDF::Reuse::Barcode 0.09 is the current stable release.
Not sure how to test this one. Do I need to install the updated PERL modules from CPAN? With the default KTD images (Debian 12 (Bookworm)), v .39 and v.07 are installed.
(In reply to David Nind from comment #2) > Not sure how to test this one. > > Do I need to install the updated PERL modules from CPAN? I started with the latest Koha Docker and installed the updated modules from CPAN. That's probably the only option until the package maintainers get to it. > > With the default KTD images (Debian 12 (Bookworm)), v .39 and v.07 are > installed. I do notice that PDF::Reuse 0.43 has been flagged in Debian for packaging. But not sure about any time frame. https://tracker.debian.org/pkg/libpdf-reuse-perl
I had a go at testing, but couldn't get the newer versions to show up under More > About Kaha > Perl modules. Do the packaged versions need to be uninstalled? A test plan would be great! Note: Non-developer testing here.
Created attachment 193669 [details] [review] Bug 41717: Bump PDF::Reuse and PDF::Reuse::Barcode versions PDF::Reuse 0.43 fixes a TTFont/docProxy lifecycle bug that caused prEnd() to crash when TrueType fonts were used. PDF::Reuse::Barcode 0.09 is the current stable release. Testing plan: - Start ktd, note older perl modules versions under About Koha - Apply patch - ktd --shell - sudo cpan -i PDF:Reuse; sudo cpan -i PDF:Reuse:Barcode - Let cpan auto set itself up (not sure if sudo is needed above) - `restart_all` - Revisit About Koha; module versions should be 0.43 & 0.09 respectively Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu>
I think I figured out how to test this and I'm seeing the updated versions under About Koha. I think it would be good to include a smoke test of some of the features that use these PDF libraries. Is that only the Patron Card Creator tool? I fiddled around with it after upgrading and was able to successfully generate PDFs, but I have never used this tool before and I couldn't figure out how to add a barcode to the cards despite trying.
(In reply to Eric Phetteplace from comment #6) > I think I figured out how to test this and I'm seeing the updated versions > under About Koha. > > I think it would be good to include a smoke test of some of the features > that use these PDF libraries. Is that only the Patron Card Creator tool? I > fiddled around with it after upgrading and was able to successfully generate > PDFs, but I have never used this tool before and I couldn't figure out how > to add a barcode to the cards despite trying. Check out bug 41719.