---- Reported by thehaven104@gmail.com 2010-02-17 00:37:40 ----

when placing a hold priority numbers are assigning numbers that are greater than 100.  

This causes the holds listing to be out of line and no longer ordered correctly.

I've added some warns to my local code to see if I can track down the issue.

current code this is present on is 3.01.00.061



---- Additional Comments From wizzyrea@gmail.com 2010-02-23 19:55:23 ----

I was able to duplicate this in 3.01.00.124.

See the following screencasts: 
http://screencast.com/t/MjEzM2Q4 --  shows erroneous priority, clearing the cache (they appear correct after), deleting the holds, and re-placing with changed pickup locations creating the error condition again.

http://screencast.com/t/NWU1MDMy -- shows how changing the pickup location when the "pickup location is different from patron's home library" prompt is shown seems to muck the priority list.



---- Additional Comments From ian.walls@bywatersolutions.com 2010-03-29 13:14:51 ----

Created an attachment
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4201 cleanup script

Run this script to cleanup damaged holds priorities accumulated due to http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4201.  It can be run in test mode (-t), which will just generate a report of how the priorities were reordered, or it can be run in live mode, which makes the changes.

Additionally, users may run the script in Aggressive mode (-a or -aggressive), which will reorder ALL holds priorities, rather than just ones that have a maximum priority greater than the number of holds.



---- Additional Comments From ian.walls@bywatersolutions.com 2010-03-29 13:15:54 ----

Patch submitted.  Please test and close.



---- Additional Comments From ian.walls@bywatersolutions.com 2010-03-31 12:53:16 ----

Created an attachment
Patch for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4201





---- Additional Comments From gmcharlt@gmail.com 2010-04-30 10:01:49 ----

Patch pushed.  Note that I do not recommend closing bugs before a commit hits mainline.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:24 UTC  ---

This bug was previously known as _bug_ 4201 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4201
Imported an attachment (id=1902)
Imported an attachment (id=1903)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was thehaven104@gmail.com.
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1902 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1903 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.