---- Reported by email@example.com 2010-03-01 08:27:59 ----
---- Additional Comments From firstname.lastname@example.org 2010-03-01 08:30:11 ----
Created an attachment
---- Additional Comments From email@example.com 2010-03-01 11:03:09 ----
*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4280 has been marked as a duplicate of this bug. ***
--- Bug imported by firstname.lastname@example.org 2010-05-21 01:25 UTC ---
This bug was previously known as _bug_ 4286 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4286
Imported an attachment (id=1978)
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
an account here. Reassigning to the person who moved
it here: email@example.com.
Previous reporter was firstname.lastname@example.org.
The original assignee of this bug does not have
an account here. Reassigning to the default assignee
for the component, email@example.com.
Previous assignee was firstname.lastname@example.org.
Setting qa contact to the default for this product.
This bug either had no qa contact or an invalid one.
The original submitter of attachment 1978 [details] [review] is unknown.
Reassigning to the person who moved it here: email@example.com.
Reopening since this bug has reappeared in the latest HEAD - 3.01.00.135
Created attachment 2189 [details]
duplicates cause of renewal
Also, if you renew the subscription to be able to accept it duplicates everything on the screen making it hard to read
The patch fails with the following..
git apply ../patches/0001-MT-3035-subscription-created-expired.patch
../patches/0001-MT-3035-subscription-created-expired.patch:42: trailing whitespace.
error: patch failed: C4/Serials.pm:987
error: C4/Serials.pm: patch does not apply
This is still an issue and kind of a big one if you're cataloging a lot of serials and have to renew each one to add items. Upping severity.
*** Bug 4280 has been marked as a duplicate of this bug. ***
Have just tried to replicate this on current HEAD and its not reproduceable. The bug whereby subscriptions were expiring immediately was caused by a problem with the generation of expiry dates from a start date. Is the system logging an error when the subscription is created
I still have this issue in my install of HEAD and in new installs. Can you tell me how to get the log you're looking for so I can get you any errors that the system is generating.
Every new subscription I create is expired at creation - or at least it requires a renewal before I can receive any issues.
Located the problem if I switch my date format to mm/dd/yyyy then new subscriptions are getting expired and subscription detail shows some odd dates like 00/02/0
Errors appear in the apache error_log or koha-dev/var/log/koha-error.log depending on how install is set up.
I'll try and post a patch today
Can people retest this bug. I cannot reproduce it using the steps I previously used to generate it.
This is still an issue.
1. New Subscription
2. Fill in all data
3. Save Subscription
4. Click 'Receive' and see that the status is grayed out and not changeable
5. Click 'Back'
6. Click 'Renew' (change nothing) just save
7. Click 'Receive' and now you can change from expected to arrived
The bug is now specific to some frequencies. There is a specific problem in serials-edit which was checking HasSubscriptionExpired as if it was a boolean. In fact that subroutine can return three values (Not expired, expired, no enddate set) I've sent a patch which explictly checks for expiration, as the third response was stopping receipting despite it being valid for some frequencies and we cannot guarantee the enddate being set on new subscriptions.
I think that patch should resolve the case I managed to reproduce. Other recently added patches mean that enddate is now being correctly set rather than left as NULL on some common cases. There are some horrible semantics in some of the expiry/prediction interface that need clearing up though.
I have signed off on the patch, it appears to solve the problem.
Created attachment 2879 [details] [review]
signed off patch
Patch pushed, please test