Bug 4475 - AmazonLocale not used consistently
Summary: AmazonLocale not used consistently
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 02:07 UTC by Katrin Fischer
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
screnshot (52.92 KB, image/png)
2010-05-10 14:07 UTC, Chris Cormack
Details
Proposed fix (4.03 KB, patch)
2010-05-10 16:24 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:37 UTC


---- Reported by katrin.fischer@bsz-bw.de 2010-05-10 14:07:14 ----

Created an attachment
screnshot

I activated all possible Amazon content and set AmazonLocale to DE/German.

If there are no reviews available, following text is shown:

Sorry, there are no reviews from this library available for this title. Add your own review

The link 'Add your own review' is 

http://www.amazon.com/review/create-review/ref=?ie=UTF8&asin=...

Should be:

http://www.amazon.DE/review/create-review/ref=?ie=UTF8&asin=...


Links on Covers are correct.



---- Additional Comments From oleonard@myacpl.org 2010-05-10 16:24:48 ----

Created an attachment
Proposed fix

This patch corrects the reviews links but does not touch the links to "images.amazon.com" There doesn't seem to be a corresponding "images.amazon.fr" or "images.amazon.de," just to name a couple. I guess the current source of cover images is working for non-US users? 



---- Additional Comments From gmcharlt@gmail.com 2010-05-11 10:21:49 ----

Pushed Owen's patch.



---- Additional Comments From katrin.fischer@bsz-bw.de 2010-05-14 09:30:33 ----

Cover images work fine, the image links to amazon.de, so I see no problem there.

The review link is to .de now, according to my setting in AmazonLocale. 





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4475 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4475
Imported an attachment (id=2122)
Imported an attachment (id=2123)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2122 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 2123 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.