Actually, the name of borrowers in 'Suggested By', 'Managed by' and 'Accepted by' lists are not display.
Created attachment 2164 [details] [review] suggestion.pl: display borrowers name in suggestion information filters (Suggested By, Managed by, Accepted by)
Patch pushed. Please test and close.
My tests (performed on 3.01.00.143 and latest HEAD): Suggested By: works functionally, but does not display the name (only has the borrowernumber in the option value) Managed By: works, both functionally and visually Accepted By: does not work either functionally or visually. Only options are 'ANY', '' and '0'.
This needs additional work before this bug can be closed
Created attachment 3423 [details] [review] New Patch
After applying this patch the suggestions page was unviewable - instead I had this: Software error: Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$delete_field" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$delete_field" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteria_list" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reasonsloop" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteria_list" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reasonsloop" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 216. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 223. Execution of /home/nengard/kohaclone/suggestion/suggestion.pl aborted due to compilation errors. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error.
This feature is already here. Something in the followup from Chris was fixed yesterday in 6046 : + if ( $displayby =~ /managedby/ || $displayby =~ /acceptedby/ || $displayby =~ /suggestedby/) { Nicole: the follow-up from Chris is wrong, it contains many <<< and === and >>> (a git conflict, not solved)