Bug 5093 - JavaScript error in IE8 when choosing authority record
Summary: JavaScript error in IE8 when choosing authority record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: Main
Hardware: All Windows
: PATCH-Sent (DO NOT USE) normal
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/cataloguing/addbiblio.p...
Keywords: browser_compatibility
Depends on:
Blocks:
 
Reported: 2010-08-05 13:42 UTC by Owen Leonard
Modified: 2013-12-05 20:04 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed fix (1.34 KB, patch)
2010-08-05 19:56 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-08-05 13:42:48 UTC
To reproduce in IE8:

- Open a blank MARC record for editing
- Choose a tag which is tied to an authority (e.g. 100a)
- Click to pop up the authority search window
- Find and choose your authority record

A maximized blank window appears and displays a JavaScript error message:

  Webpage error details

  User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0;)
  Message: Not implemented

  Line: 123
  Char: 5
  Code: 0
  URI: /cgi-bin/koha/authorities/blinddetail-biblio-search.pl?authid=1&index=tag_100_subfield_a_342534_649318

This blank window does not close itself as it does under normal operation. However, after manually closing the window you'll find the authority information was populated in the MARC record form as expected.
Comment 1 Owen Leonard 2010-08-05 19:56:25 UTC
Created attachment 2477 [details] [review]
Proposed fix

Changing onload() to jQuery's $(document).ready() gets it working.
Comment 2 Chris Cormack 2010-12-14 02:04:50 UTC
Patch is awating sign off
Comment 3 Chris Cormack 2011-05-30 08:08:42 UTC
This needs a rebase for Template::Toolkit, you OK doing that owen or do you want me to take a crack?
Comment 4 Owen Leonard 2011-05-31 19:44:54 UTC
This patch seems to have already been pushed. The current file includes the changes in the attached patch. It tests successfully for me with Internet Explorer 8 on Windows 7. If someone else can confirm we should be able to close this one.
Comment 5 Jared Camins-Esakov 2012-12-31 00:18:57 UTC
There have been no further reports of problems so I am marking this bug resolved.