The description for the preference says "show/don't show an item's branch, location and call number in OPAC search results." The preference works with normal results, the alternatives being: Availability: Copies available: Athens (1) ("don't show") and Availability: Copies available: Athens [AF Needle] (1) ("show") In the OPAC's XSLT results display the latter version appears no matter what the preference is set to.
*** Bug 2619 has been marked as a duplicate of this bug. ***
This appears to still be valid.
The preference description is inaccurate: "show/don't show an item's branch, location and call number in OPAC search results." It does not affect display of branch, only location and callnumber. OPACItemLocation has an option for 'only branch' which seems to be equivalent functionality. Can we just link the preferences to display together and indicate one is XSLT and one is not?
I think a goal is to remove the non-XSLT display this release - so I think better to work towards that.
(In reply to Katrin Fischer from comment #4) > I think a goal is to remove the non-XSLT display this release - so I think > better to work towards that. So then we simply remove this preference?
If we can confirm that there is equal functionality for the XSLT view - I think that would be consequential.
Hum... We removed the feature but forgot the syspref. commit 56c2856e268ec02638898923d751a0b69c716f93 Bug 12561: Remove non-XSLT views
Renaming bug report, we should now just remove the pref.
Created attachment 127631 [details] [review] Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed.
Created attachment 127655 [details] [review] Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed.
Created attachment 127689 [details] [review] Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 127690 [details] [review] Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
QAing
Created attachment 127821 [details] [review] Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 127822 [details] [review] Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 127823 [details] [review] Bug 5229: (QA follow-up) Remove last occurrence in code Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Marcel de Rooy from comment #16) > Created attachment 127823 [details] [review] [review] > Bug 5229: (QA follow-up) Remove last occurrence in code > > Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I let it there on purpose. At the time it made sense to keep it, today I don't know why we should keep it :D I will skip the patch as it will (easy) conflict with bug 29494 that is removing completely the file.
Pushed to master for 21.11, thanks to everybody involved!