Bug 5252 - Emails & Phones On Patron Add/Edit form
Summary: Emails & Phones On Patron Add/Edit form
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nicole C. Engard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-25 14:30 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
phone/email choices (27.61 KB, image/png)
2010-09-25 14:30 UTC, Nicole C. Engard
Details
patch (11.26 KB, patch)
2011-08-09 15:26 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Signed-off patch (11.36 KB, patch)
2011-08-12 15:27 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-09-25 14:30:11 UTC
Created attachment 2647 [details]
phone/email choices

The way it is now the home email and phone show on the transit slips and in the summary of the patron's info on the left of the patron pages.  People use different phones as their primary phones and so I suggest we change the Email & Phone section to match those of Gmail where you can choose what type of phone or email account you are adding.  See attached.  

I'm not suggesting we let people add as many as they want (that might be a bit harder), but that we add pull downs to identify which phone/email is the primary and which should be used next.
Comment 1 Jane Wagner 2010-09-27 11:33:41 UTC
Are you proposing to use the same underlying table field, but let the patron identify it as desired?  Or let the patron say which of the existing fields should be the primary field?  If the latter, then this would also involve changes to the notice scripts (overdue, and I'm assuming other notices as well).  Right now, the choice of email to use is through the syspref AutoEmailPrimaryAddress and there is no heirarchy.  The email field specified in that syspref is used for all patrons.
Comment 2 Nicole C. Engard 2010-09-27 12:57:06 UTC
I am proposing whatever option makes it so that things work and the library has more control over what labels are assigned to emails and phones.

So we can keep the table structure and add a few fields for the labels.  We can then update the template to have the pull downs and include a note on the first phone and the first email that says 'primary.'

This is just one of multiple ways that I'm sure this can be done, I'm open to whatever makes it more customizable than it is now (without having to use JQuery to change the labels).
Comment 3 Liz Rea 2010-09-28 20:26:48 UTC
NEKLS handles this by merely changing the labels: 

Primary email/phone for the one they want contacted
Secondary email/phone for the alternate.

This way, it's *really* non-specific. Just put the info you want to be contacted at in the primary, and the others in the secondary, and it doesn't matter what personal location the info belongs to.

<rant>Which leads to a personal peeve of mine: that it matters which phone is your home, your work, or your mobile. If I tell you to contact me at a number, that's where I want you to call. I don't want any entity calling me on any number other than the one I give them as my primary: businesses shouldn't be making decisions based on their arbitrary definition of my number.  I should be making that decision by which number I give them as my primary. Same goes for email. </rant>
Comment 4 Liz Rea 2010-09-28 20:28:43 UTC
I suppose I should say, I am for changing the labels on the fields and leaving the underlying structure alone (thus meeting your no jquery requirement).
Comment 5 Nicole C. Engard 2010-09-28 20:40:01 UTC
This too is fine with me - discussions on the developer list seemed to say that others did care what kind of number it was.  I just want it clear that the first email and phone are the most important - and do not really have to be for "home"
Comment 6 Nicole C. Engard 2011-08-09 15:25:41 UTC
A patch has been submitted here that is a step in the right direction.  It changes the labels to make it clearer for the patrons and the staff.

phone is now 'Primary phone', mobile is now 'Secondary phone', and 'phonepro' is now 'Other phone'. This way the type of phone does not matter and the phone that the patron wants to be called at the most is the 'primary.'

This is just a step in the direction of fixing Bug 5252, not a complete fix.  Database field names will eventually need to be changed for clarity and the option to have pull downs to type the phone numbers (as I suggested earlier) would be great.

This patch also updated a stray reference to Home Email.  Both the OPAC and staff client are updated with this patch.
Comment 7 Nicole C. Engard 2011-08-09 15:26:10 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2011-08-12 15:27:42 UTC
Created attachment 4983 [details] [review]
Signed-off patch
Comment 9 Ian Walls 2011-08-12 15:32:55 UTC
Template only change, easy to read, improves usability for most usecases.  Marking as Passed QA.
Comment 10 Chris Cormack 2011-08-14 08:10:38 UTC
Pushed, please test
Comment 11 Nicole C. Engard 2011-08-16 23:15:50 UTC
Reopening as an enhancement in case someone wants to come up with a better fix, but the patch that was pushed works for now.
Comment 12 Chris Nighswonger 2011-10-26 18:02:09 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.