Openlibrary has an API very similair to google books, we should enable Koha to use it to fetch book covers
Patch sent to the mailing list
Created attachment 4723 [details] [review]
Created attachment 4724 [details] [review]
Follow up patch
Created attachment 4725 [details] [review]
Follow up patch
I have signed off on these patches since they do what they say they do - but if there is any way to have bigger cover images I'd love to see a follow up patch that does that. The covers do appear a bit too small compared to other cover image services.
Created attachment 4726 [details] [review]
Signed-off patch 1/2
Created attachment 4727 [details] [review]
Signed-off patch 2/2
The patches work as advertised, so I'm signing off.
However, I think the "small" version of the covers is too small to be of much use, at least for the examples I have seen, e.g.:
The "medium" version is of course too big:
but would it be possible to use the medium version and scale it down somewhat, with CSS or dimensions set on the img tag?
That last URL should of course be:
You repeated exactly what I said :) Glad I'm not alone. I did not however attach my signed off patches here ... just FYI.
Created attachment 4822 [details] [review]
proposed patch (passed QA)
Created attachment 4823 [details] [review]
proposed patch 2 (passed QA)
Created attachment 4824 [details] [review]
proposed patch 3 (passed QA)
No comment, works fine, nothing to notice, except, as others, the size of the image, that is quite small.
I've added a 3rd patch, with the version number (chris : 006, take care of applying the 005 i've validated a few hours ago before)
I also have rebased the first one, for a small/easy to fix updatedatabase glitch
For future reference, it is easier/better for me if you leave the updatedabase as XXX and don't change the kohaversion
I don't always apply them in the order you have numbered them, and its easier for me to just set the version when they are applied to master.
opening a new ticket to recommend that the cover images be bigger, but this patch works as expected.