Bug 5454 - Resolve BiblioAddAuthorities Name Conflict in addbiblio.pl
Summary: Resolve BiblioAddAuthorities Name Conflict in addbiblio.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on: 7284
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-29 11:52 UTC by Colin Campbell
Modified: 2013-12-05 20:05 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2010-11-29 11:52:12 UTC 
cataloguing/addbiblio.pl has a routine BiblioAddAuthorities which is almost identical to the subroutine of that name imported from Search.

Name clash should be resolved. If code exists in two places at least one is bound to be wrong
Comment 1 Galen Charlton 2011-03-03 21:40:33 UTC 
Furthermore, the core routine BiblioAddAuthorities should not be in C4::Search.  C4::Biblio, C4::AuthoritiesMarc, or perhaps a new module would be better.
Comment 2 Jared Camins-Esakov 2012-01-07 17:02:27 UTC 
This will be fixed as a side effect of the work on bug 7284.
Comment 3 Jared Camins-Esakov 2013-04-03 12:23:00 UTC 
As stated in comment 2, this was fixed by bug 7284.