When searching for patrons to add to a batch for creating patron cards, you can search by name or "category code." Category code is a text input field. It would be better for this to be a drop-down menu of existing categories.
Patron category is still a free text field on current master.
This bug is still valid in master as of 3.12 beta1.
Created attachment 29646 [details] [review] Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly.
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Created attachment 29688 [details] [review] Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 29827 [details] [review] [PASSED QA] Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Owen!