Bug 5502 - Patron card category search field should be menu
Summary: Patron card category search field should be menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/patroncards/members-sea...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 15:23 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 5502 - Patron card category search field should be menu (6.58 KB, patch)
2014-07-11 15:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 5502 - Patron card category search field should be menu (6.59 KB, patch)
2014-07-15 00:47 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 5502 - Patron card category search field should be menu (6.65 KB, patch)
2014-07-18 12:43 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-12-15 15:23:52 UTC
When searching for patrons to add to a batch for creating patron cards, you can search by name or "category code." Category code is a text input field. It would be better for this to be a drop-down menu of existing categories.
Comment 1 Katrin Fischer 2011-05-27 05:57:06 UTC
Patron category is still a free text field on current master.
Comment 2 Owen Leonard 2013-03-26 15:54:40 UTC
This bug is still valid in master as of 3.12 beta1.
Comment 3 Owen Leonard 2014-07-11 15:31:01 UTC Comment hidden (obsolete)
Comment 4 Biblibre Sandboxes 2014-07-15 00:47:40 UTC
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 5 Biblibre Sandboxes 2014-07-15 00:47:57 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2014-07-18 12:43:36 UTC
Created attachment 29827 [details] [review]
[PASSED QA] Bug 5502 - Patron card category search field should be menu

When searching for patrons to add to a patron card creator batch there
is a text input field for submitting a patron category. This should be a
dropdown menu. This patch corrects it.

To test, go to Tools -> Patron card creator and click "New batch."
 - Click the "Add item(s)" button.
 - Confirm that in the Patron search pop-up window there is a dropdown
   menu populated with existing patron categories.
 - Confirm that searches limited by patron category return correct
   results.
 - Confirm that the correct patron category is automatically preselected
   after performing a search limited by category.
 - Confirm that reordering the table of search results works correctly.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2014-08-10 12:39:27 UTC
Patch pushed to master.

Thanks Owen!