Bug 5636 - clean borrowers run from command line
Summary: clean borrowers run from command line
Status: RESOLVED DUPLICATE of bug 6572
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P2 enhancement (vote)
Assignee: Alex Arnaud
QA Contact:
URL:
Keywords:
: 4916 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-19 20:57 UTC by Paul Poulain
Modified: 2013-06-05 14:28 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
BZ5636 MT#4916 permit tools/cleanborrowers.pl to be used by command line (3.22 KB, patch)
2011-05-29 07:45 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-01-19 20:57:55 UTC
in France, the anonymization of issues & patrons is defined by law. So it can be crontab-ed.
We will add command line feature to the script
Comment 1 Owen Leonard 2011-01-31 20:08:09 UTC
*** Bug 4916 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2011-01-31 20:09:10 UTC
Patch submitted to the patches list:

http://lists.koha-community.org/pipermail/koha-patches/2011-January/013667.html
Comment 3 Chris Cormack 2011-05-29 07:45:12 UTC
Created attachment 4290 [details] [review]
BZ5636 MT#4916 permit tools/cleanborrowers.pl to be used by command line

This patchs adds the possibility to run the script by command line.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Ian Walls 2011-08-11 17:21:24 UTC
Style question to the community:  should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff client AND a command-line presence, or should the commandline tool be a separate script in misc/?

At this time, there doesn't seem to be any precedent for inclusion in the core script.  Before passing this patch for QA, I'd like to get some feedback, as this may both open doors for us, as well as create additional work to create consistency of implementation for existing jobs.
Comment 5 Paul Poulain 2011-08-31 14:39:22 UTC
dropped a mail with ian's question to koha-devel, to have answers/opinions
Comment 6 Paul Poulain 2011-09-12 11:30:38 UTC
seems Marcel & me have the same opinion : don't decide anything, there are only a few cases where it's functionnally relevant.
No one elses answered.( http://lists.koha-community.org/pipermail/koha-devel/2011-August/036126.html)

Ian QA welcomed ;-)
Comment 7 Paul Poulain 2011-10-24 11:40:15 UTC
Updating version : This ENH could be in Koha 3.8
Comment 8 Paul Poulain 2011-10-25 15:05:52 UTC
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Comment 9 Marcel de Rooy 2011-11-10 14:39:35 UTC
Ian,
Code looks good to me.
I would suggest to let it pass QA (pragmatic approach).
Comment 10 Marcel de Rooy 2011-12-14 12:30:47 UTC
In view of the community response on the ml, with reference to Galen's comment on security, and the repeated argument of putting the shared code in modules, I think we should conclude that this patch [unfortunately] cannot be pushed in its current form.
Changing patch status.
Comment 11 Paul Poulain 2012-01-19 15:01:13 UTC
Alex, you've been randomly choosen to rewrite this patch ;-)

Please submit a script to clean_borrowers in misc/cronjobs directory, as http & commandline scripts must be in separate directories.
Comment 12 Paul Poulain 2012-02-13 13:59:55 UTC
the patch attached here does not have to be signed off, it must be rewritten, removing "need signoff" status
Comment 13 Jared Camins-Esakov 2013-01-02 02:07:07 UTC
Resetting assignee to Alex Arnaud, since Paul delegated this to him.
Comment 14 Jonathan Druart 2013-06-05 13:37:29 UTC
This patch add a script which allow to
1/ Anonymize patron history => Done in misc/cronjobs/batch_anonymise.pl (bug 6572)
2/ Delete patrons => I will open a new report for that

*** This bug has been marked as a duplicate of bug 6572 ***
Comment 15 Jonathan Druart 2013-06-05 14:28:01 UTC
A script for deleting patron will be on bug 10419