When choosing icons for item types or authorized values the icons appear in alpha order in rows, however if the icon set has icons in multiple sizes (as three of our sets do) then the rows get all scattered and the icons look clumped together. I'd like to see a better style here that keeps the icons in neat rows.
Created attachment 3016 [details]
example of messy view
Created attachment 16842 [details] [review]
Created attachment 16844 [details]
screenshot with patch
Working fine when you're choosing icons for item types. Not apply when you are modifying authorized values and you want to choose icons for them (in admin-->authorised values).
Hmm, setting this back to needs signoff, as it does fix a problem, causes no regressions, and a follow up could be sent to address the icons in authorised values.
Let's encourage our new developers, not dishearten them
Upgrading to bug.
I agree with Chris and Jared - they just beat me to add a comment :)
Re-upgrading to bug.
Oh, I didn't intent to change back to enh - glad you spotted it.
(En réponse au commentaire 5)
> Hmm, setting this back to needs signoff, as it does fix a problem, causes no
> regressions, and a follow up could be sent to address the icons in
> authorised values.
> Let's encourage our new developers, not dishearten them
It was not my goal to discourage anyone, it s more about a bad choice with bug's status, my fault, sorry for that. Will be more careful next time.
Hi Frederic, sorry if that came over a bit harsh - I think we should also port this fix to the authorised value page, but sometimes it's good to get a small improvement in. I have opened bug 9945 for that. Thank you for your testing :)
Small patch. It fixes an ergonomic issue.
Marked as Passed QA.
Created attachment 16971 [details] [review]
Bug 5648: Changed display: inline to inline-block on the inline CSS styling on the li elements.
Signed-off-by: Frédéric Durand <email@example.com>
Signed-off-by: Jonathan Druart <firstname.lastname@example.org>
This patch has been pushed to master.
Welcome, Jen, you are the 205th committer!
Pushed to 3.8.x and 3.10.x will be in 3.8.12 and 3.10.5