Bug 5727 - Use of uninitialized value in concatenation (.) or string
Summary: Use of uninitialized value in concatenation (.) or string
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 17:34 UTC by Frédéric Demians
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Warning from XSLT.pm (1.21 KB, patch)
2011-02-09 17:43 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 5725 : Batch Modifications for Biblios (32.22 KB, patch)
2012-07-02 15:41 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2011-02-09 17:34:54 UTC
A lot of 'Use of uninitialized value in concatenation (.) or string' pollute log files and make them unreadable.
Comment 1 Frédéric Demians 2011-02-09 17:43:35 UTC
Created attachment 3114 [details] [review]
Warning from XSLT.pm
Comment 2 Chris Cormack 2011-02-13 20:56:51 UTC
Pushed, please test and mark resolved
Comment 3 Paul Poulain 2012-07-02 15:41:39 UTC
Created attachment 10609 [details] [review]
Bug 5725 : Batch Modifications for Biblios

commit 66282fed94564969f0368e27c7231116a2d1c0fe
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Feb 22 08:43:24 2011 +1300

    Bug 5725 : Follow up fixing permissions thanks to Paul Poulain

commit 4d0241aea5be13b00abbc6100dc98ec87f816081
Author: Paul Poulain <paul.poulain@biblibre.com>
Date:   Mon Jan 10 17:22:31 2011 +0100

    Bug 5725 follow up

    Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API
    (the 1st returned arg is useless)
    This patch is not in main trunk, resulting in the error owen has noticed.

    This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore)

commit 19b3e0ecc57af1c2151340328bf06e26882b7863
Author: Paul Poulain <paul.poulain@biblibre.com>
Date:   Wed Dec 15 20:47:21 2010 +0100

    Bug 5725 : MT #2991 (Feature) Batch biblio modifications

    This patch add a new feature of batch biblio modifications,
    it permit to select biblios from basket, and modify fields of them setting

    Rebased to fix whitespace issues.

Bug 5725 follow-up Fixes adresses comments 28 and 29 (from Owen)

* add a link to tools-home
* display the biblios before defining rules
* add some help/change some wording
* fixes result "Status" column (was a H:T:P => T:T glitch) and put the message on the top

I also removed an unused variable

Bug 5725 follow-upd, deal with leader

As Owen comment 33 notices, leader update was not working. This patch fixes the problem (and fix a few reindenting glitches as well)

Additional fixes for Bug 5725 - Batch modifications for Biblios

- Correcting page title
- Adding breadcrums
- Adding sidebar menu (matching other batch mod pages)
- Showing "loading" graphic during AJAX operations
- Adding empty option to list of MARC tags so that onchange event
  will fire when the user is choosing 000
- Other structural markup changes