Bug 5741 - Extra comma causes JavaScript error in Internet Explorer
Summary: Extra comma causes JavaScript error in Internet Explorer
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
: 5762 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-11 17:40 UTC by Owen Leonard
Modified: 2012-10-25 23:04 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed fix (1.01 KB, patch)
2011-02-11 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
removes stray comma at end of js list in 8 files (8.04 KB, patch)
2011-02-15 01:05 UTC, Reed Wade
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-02-11 17:40:00 UTC
A trailing comma on the last item causes an error:

Calendar.setup(
  {
     inputField : "newduedate",
     ifFormat : "<!-- TMPL_VAR NAME="DHTMLcalendar_dateformat" -->",
     button : "newduedate_button",
     disableFunc : validate1,
     dateStatusFunc : validate1,
   }
);

See: http://wiki.koha-community.org/wiki/Coding_Guidelines#JavaScript
Comment 1 Owen Leonard 2011-02-11 17:42:14 UTC
Created attachment 3130 [details] [review]
Proposed fix
Comment 2 Reed Wade 2011-02-15 01:05:04 UTC
Created attachment 3154 [details] [review]
removes stray comma at end of js list in 8 files

This one probably obsoletes the earlier proposed fix. It covers more cases.
Comment 3 Reed Wade 2011-02-15 01:06:28 UTC
Catalyst work on this item sponsored by Opus.
Comment 4 Chris Cormack 2011-02-15 18:01:20 UTC
*** Bug 5762 has been marked as a duplicate of this bug. ***
Comment 5 Chris Cormack 2011-02-20 07:33:20 UTC
Signed off and pushed, please test
Comment 6 MJ Ray (software.coop) 2011-03-07 09:39:39 UTC
This bug is mentioned in:
Fix for Bug 5741 - Extra comma causes	JavaScript error in Internet Explorer http://lists.koha-community.org/pipermail/koha-patches/2011-February/013834.html
Bug 5741 - Extra comma causes JavaScript	error in Internet Explorer http://lists.koha-community.org/pipermail/koha-patches/2011-February/013865.html