Created attachment 3318 [details] [review]
Tested on master and works as expected.
Pushed, I do not there are no tests for these new subroutines, you would win much respect and joy and kudos and the people would praise your name, if you had unit tests for any new functions you write :)
Please test and mark resolved
Pod says GetAuthorisedValueByCode returns a hashref code returns a scalar.
Thats why we need tests
well, we need test, but test can't check pod is lying ;-)
(julian is writing a test anyway)
Created attachment 3336 [details] [review]
Follow up patch
Unit tests are there !
Created attachment 3340 [details] [review]
Improved unit tests
Follow up patches with unit tests pushed. Kudos to Biblibre and Julian!
Created attachment 3399 [details] [review]
Follow-up patch to correct error in pod
Corrected the error in the documentation in a supplementary patch
Follow up patch pushed, Thanks Colin
This bug is mentioned in:
Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues http://lists.koha-community.org/pipermail/koha-patches/2011-March/014075.html
Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues http://lists.koha-community.org/pipermail/koha-patches/2011-March/014080.html
Follow up for bug 5880: Added unit tests for the two new subroutines http://lists.koha-community.org/pipermail/koha-patches/2011-March/014106.html
Follow up for bug 5880: Improved unit test http://lists.koha-community.org/pipermail/koha-patches/2011-March/014111.html
Bug 5880: Correct misleading pod in new subroutine http://lists.koha-community.org/pipermail/koha-patches/2011-March/014189.html