Bug 5916 - Don't show the link to edit authorities to people who don't have permissions to edit
Summary: Don't show the link to edit authorities to people who don't have permissions ...
Status: RESOLVED DUPLICATE of bug 10888
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Christophe Croullebois
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5581
  Show dependency treegraph
 
Reported: 2011-03-21 03:18 UTC by Chris Cormack
Modified: 2013-09-13 18:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.31 KB, patch)
2011-03-21 03:39 UTC, Chris Cormack
Details | Diff | Splinter Review
'Edit' link (3.44 KB, image/png)
2011-03-22 13:12 UTC, Julian Maurice
Details
proposed patch (updated) (2.48 KB, patch)
2011-09-05 16:13 UTC, Paul Poulain
Details | Diff | Splinter Review
patron permissions (147.99 KB, image/png)
2011-09-07 13:13 UTC, Nicole C. Engard
Details
able to edit authorities (215.58 KB, image/png)
2011-09-07 13:14 UTC, Nicole C. Engard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-21 03:18:04 UTC

    
Comment 1 Chris Cormack 2011-03-21 03:39:09 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2011-03-22 13:12:08 UTC Comment hidden (obsolete)
Comment 3 MJ Ray (software.coop) 2011-04-09 09:25:51 UTC
This bug is mentioned in:
Bug 5916 : (MT #2685) don't show authority	edition menu http://lists.koha-community.org/pipermail/koha-patches/2011-March/014157.html
Comment 4 Paul Poulain 2011-09-05 16:13:12 UTC
Created attachment 5311 [details] [review]
proposed patch (updated)

The proposed patch was for H::T. As the file affected was .inc, that also exist for T::T, it was still applying, but no more working.

This patch has been updated for T::T (+ few reindenting fixed + javascript variable put into the IF)

I tested successfully this patch, please sign-off
Comment 5 Paul Poulain 2011-09-05 16:13:46 UTC
it's not an enh, but a minor bugfix and back to "need signoff"
Comment 6 Nicole C. Engard 2011-09-06 13:44:27 UTC
After applying this patch I still see edit authority on this page:

cgi-bin/koha/authorities/auth_finder.pl?op=do_search&type=intranet&index=tag_100_subfield_a_22862_738128&authtypecode=PERSO_NAME&marclist=mainmainentry&and_or=and&operator=contains&value_mainstr=k&marclist=mainentry&and_or=and&operator=contains&and_or=and&operator=contains&orderby=HeadingAsc

I'm not sure where this patch was supposed to remove that link from because it's not clear from the patch description.  Please let me know all the places to look when the updated patch is submitted.
Comment 7 Paul Poulain 2011-09-07 12:56:32 UTC
Nicole: if you don't have the manage authority (editauthorities) permission the link is not displayed. Are you sure you've checked without superlibrarian and no editauthorities permission ?
Comment 8 Nicole C. Engard 2011-09-07 13:10:50 UTC
Yup,

The librarian I tested with had cataloging permissions and some circulation permissions but not editauthorities.  I'll test again and get you a screenshot of the permissions my staff user has.

Nicole
Comment 9 Nicole C. Engard 2011-09-07 13:13:42 UTC
Created attachment 5337 [details]
patron permissions

I tested again with this patron.
Comment 10 Nicole C. Engard 2011-09-07 13:14:18 UTC
Created attachment 5338 [details]
able to edit authorities

The link to edit authorities is still showing even though she doesn't have the right permissions.

I tried in Firefox and Chrome.
Comment 11 Owen Leonard 2011-10-07 15:44:24 UTC
Marking Failed QA based on comment 10.
Comment 12 Owen Leonard 2013-09-13 18:56:14 UTC

*** This bug has been marked as a duplicate of bug 10888 ***