Bug 5929 - Use branch admin email for advance_notice.pl emails
Summary: Use branch admin email for advance_notice.pl emails
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5544
  Show dependency treegraph
 
Reported: 2011-03-22 01:15 UTC by Shelley
Modified: 2012-10-25 23:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (8.15 KB, patch)
2011-03-22 06:07 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
patch (810 bytes, patch)
2011-03-28 23:44 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
Squashed, Signed off commit for fix (10.28 KB, patch)
2011-06-03 20:32 UTC, Ian Walls
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Shelley 2011-03-22 01:15:46 UTC
Instead of using the KohaAdminEmailAddress system preference, the PREDUE and DUE notices should send 'from' the email address configured in the branch management area, just like Overdues. KohaAdminEmailAddress should be a fallback if no address is configured for the branch. 

The branch selected should be the same as is selected for overdues.


Work to be done: 
  -  Find the patch that added the functionality to overdues 
  -  Duplicate the functionality for DUE and PREDUE templates
Comment 1 Srdjan Jankovic 2011-03-22 06:07:58 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2011-03-28 23:44:56 UTC Comment hidden (obsolete)
Comment 3 Ian Walls 2011-06-03 20:32:55 UTC
Created attachment 4355 [details] [review]
Squashed, Signed off commit for fix

Takes the previous two attachments, squashes, and adds a minor fix to template toolkit compatibility.
Comment 4 Chris Cormack 2011-06-04 07:41:28 UTC
Pushed to master please test
Comment 5 Ian Walls 2011-08-02 20:23:14 UTC
Tested on production system, works.  Marking as resolved.