If an item is returned at other than its' home library, and there is a hold for it--at any library other than the return library--two prompts come up: one telling the user to send the item home, and the other, to confirm and transfer for the hold. Only the latter should be displayed.
(Patch coming shortly; this is an easy one.)
Created attachment 3537 [details] [review]
Patch pushd please test
This bug is mentioned in:
Bug 6004/3270: Sending things "home" http://lists.koha-community.org/pipermail/koha-patches/2011-March/014361.html
The definition of $hbr is problematic in this patch
$hbr is defined as HomeOrHoldingBranchReturn, not uniformly homebranch, which is fine, set it to homebranch, and you're good to go, but if you're in IndependantBranches, that means you can't check the item back in at the library that issued it. If you have it set to holdingbranch then you won't be prompted to transfer it to it's homebranch if you have AutoItemReturn set to yes; it'll just stay at the holdingbranch
Tere's no way in IndependantBranches to send the item home automatically
if HomeOrHoldingBranchReturn = homebranch, you can't check it back in.
if HomeOrHoldingBranchReturn = holdingbranch, it stays where it's returned
HomeOrHoldingBranchReturn is being used two different ways in AddReturn, once to define which branch the items is allowed to be returned to (in IndependantBranches mode) and the other to determine where it should go after return.
There have been no further reports of problems so I am marking this bug resolved.