Bug 6010 - Can't save system preferences on IE8
Summary: Can't save system preferences on IE8
Status: CLOSED DUPLICATE of bug 5862
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Frédérick Capovilla
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 19:29 UTC by Frédérick Capovilla
Modified: 2012-10-26 00:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Corrects a javascript error on IE8 when trying to save preferences. (1.60 KB, patch)
2011-03-30 19:29 UTC, Frédérick Capovilla 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2011-03-30 19:29:52 UTC 
Created attachment 3541 [details] [review]
Corrects a javascript error on IE8 when trying to save preferences.

When trying to save system preferences in "/admin/preferences.pl", an error is returned when clicking on the Save button in IE8 :

----------------------------------------
Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727)
Timestamp: Wed, 30 Mar 2011 19:25:09 UTC


Message: 'this.localName' is null or not an object
Line: 40
Char: 17
Code: 0
URI: https://www.******.com/intranet-tmpl/prog/en/js/ajax.js
-----------------------------------------

It looks like elem.localName isn't supported by IE8. I modified ajax.js so it uses elem.nodeName instead, which should be equivalent and has better cross-browser support.

Patch attached, please test.
Comment 1 Owen Leonard 2011-03-30 20:19:45 UTC 
This seems to be a duplicate of Bug 5862. A patch for that has been pushed to both master and 3.2.x.
Comment 2 Frédérick Capovilla 2011-03-31 22:01:03 UTC 

*** This bug has been marked as a duplicate of bug 5862 ***