Bug 6018 - Batch modifitcation of items Enchancements
Summary: Batch modifitcation of items Enchancements
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Julian Maurice
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5992 6068
  Show dependency treegraph
 
Reported: 2011-03-31 02:06 UTC by Chris Cormack
Modified: 2020-11-30 21:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (8.84 KB, patch)
2011-03-31 02:14 UTC, Chris Cormack
Details | Diff | Splinter Review
Followup patch (15.44 KB, patch)
2011-03-31 02:14 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-31 02:06:55 UTC

    
Comment 1 Chris Cormack 2011-03-31 02:14:26 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-03-31 02:14:43 UTC
Created attachment 3562 [details] [review]
Followup patch
Comment 3 Chris Cormack 2011-03-31 02:34:15 UTC
MT3269 : BatchMod Feature blanking subfields

there is now a checkbox after each label that you can check
in order to wipe out the corresponding subfield in all the items

MT3269 Fixing tools/batchMod.pl tags/subfields display

display all the subfields  used in framework no matter if they are hidden or shown
Comment 4 Nicole C. Engard 2011-03-31 14:27:38 UTC
On testing the first patch I find that only the first item has it's value changed. I had 2 items and chose a shelving location value and it only applied to the first item - not both of them.

I also chose to remove that shelving location using the checkbox and nothing happened ... 

when I applied the follow up I got the following on the batch item mod page:


Software error:

syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 326, near "elsif"
Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327.
Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327.
Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327.
Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 331.
Global symbol "%authorised_lib" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 332.
syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 336, near "}"
Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 337.
Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 337.
Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338.
Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338.
Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338.
Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 345.
Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 345.
Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 347.
Global symbol "%authorised_lib" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 348.
Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 350.
Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 350.
syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 353, near "}"
/home/nengard/kohaclone/tools/batchMod.pl has too many errors.
Comment 5 Nicole C. Engard 2011-03-31 14:30:15 UTC
I tested without the patches to confirm that modification did work before the patch and when I modified both items both items were changed - so this patch breaks the tool.
Comment 6 MJ Ray (software.coop) 2011-04-06 13:51:49 UTC
This bug is mentioned in:
Bug 6018 : MT3269 : BatchMod Feature	blanking subfields http://lists.koha-community.org/pipermail/koha-patches/2011-March/014386.html
Bug 6018 : MT3269 Fixing	tools/batchMod.pl tags/subfields display http://lists.koha-community.org/pipermail/koha-patches/2011-March/014387.html
Comment 7 Paul Poulain 2011-04-08 15:15:43 UTC
Julian, can you have a look please ? It works well on biblibre/master, libraries have used this for months and on thousands of items at once. (Or maybe bug chris_c)
Comment 8 Julian Maurice 2011-12-02 14:07:34 UTC
It seems that the first patch is already in master (see bug 6068).
But the second patch does not apply on master.

Applying: Bug 6018 : MT3269 Fixing tools/batchMod.pl tags/subfields display
/home/julian/koha/versions/community-master/.git/rebase-apply/patch:14: trailing whitespace.
use C4::Branch; 
/home/julian/koha/versions/community-master/.git/rebase-apply/patch:50: space before tab in indent.
   	next if ($tag ne $itemtagfield);
/home/julian/koha/versions/community-master/.git/rebase-apply/patch:56: space before tab in indent.
     	next if (!defined ($tagslib->{$tag}->{$subfield}->{'tab'}) || $tagslib->{$tag}->{$subfield}->{'tab'} eq -1);
/home/julian/koha/versions/community-master/.git/rebase-apply/patch:89: trailing whitespace.
                $attributes_no_value = qq(disabled="disabled"); 
/home/julian/koha/versions/community-master/.git/rebase-apply/patch:162: trailing whitespace.
                
error: patch failed: tools/batchMod.pl:27
error: tools/batchMod.pl: patch does not apply
Patch failed at 0001 Bug 6018 : MT3269 Fixing tools/batchMod.pl tags/subfields display
Comment 9 Katrin Fischer 2012-06-11 14:36:27 UTC
I think the second patch is still needed. I tried batch editing an item from the fast add framework and for example $i does not show up in the list of item fields.
Comment 10 Katrin Fischer 2012-06-11 14:38:13 UTC
Second patch does not apply and can't fix the conflict.
Comment 11 Julian Maurice 2012-06-20 12:13:57 UTC
It's an old patch and I don't remember what it does...
Is the only need to display all subfields, whatever the hidden value is?
In this case I can make another patch much more simple.
Comment 12 Katrin Fischer 2012-06-20 14:05:04 UTC
I think it might be good to show all subfields, because you can have items from different frameworks on your list easily. Not sure which framework is used in this case currently? There are also fields like onloan you don't want people to batch edit. I am not sure, what the best solution here is.
Comment 13 Marc Véron 2016-10-03 15:24:42 UTC
Still valid?
Comment 14 Julian Maurice 2020-05-22 09:23:59 UTC
No activity since 2012, and it's not clear what the patch is supposed to do. I think we can close this bug.