Created attachment 3585 [details] [review]
Created attachment 3588 [details] [review]
The first patch has the wrong address for the Free Software Foundation, Can we get a followup that corrects that please?
Created attachment 5441 [details] [review]
Fix Free Software Foundation address
Updating Version : This ENH will be for Koha 3.8
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
can you provide a test plan for this? In which circumstances one would use the script? The second patch seems to delete all documentation about the script?
All 3 patches still apply to master.
Created attachment 7438 [details] [review]
This script is to be used when the statistics table is incomplete.
It happened to one of our customers: because of a database inconsistency, the statistics table was not populated during some time.
This script was created to recreate those missing statistics from the issues and old_issues tables data.
I can't figure out why the documentation was removed from the script with the second patch, though.
Anyhow, I found a more recent version in our repository, which I attached. It adds counters for the number of issues, renewals, and returns added, as well as command-line options for processing only issues or only returns.
thx for your explanation! Sounds like this could be a tool for migrations too?
I only have a very small testing database with almost no circulation activities - so it's a bit hard to test for me. Perhaps someone else with a bigger database might be willing to give this a try?
Test ok on sandbox
Script is self-contained, so it won't affect other parts of the code (beyond updating the statistics table).
Works on both issues and renewals, though I find it a little odd that not specifying either specifies both... just a comment, not a problem.
Looks to be a very useful tool for recreating lost statistics (as best as one can). Could be handy for migrations.
Marking as Passed QA.
versionned for 3.8, to be sure I document it in my release notes, may be applied to 3.6 safely
There have been no further reports of problems so I am marking this bug resolved.