Created attachment 3828 [details] [review] proposed patch Show local help and isbd punctuation automatically when we are cataloguing. In administration->MARC Bibliographic framework->Marc Structure->Subfields->Edit subfields there are two new fields, punctuacion and help. We have to fill those fields with some help and the isbd punctuation to a determinate subfield. Those values will appear when we are cataloguing. Our libraries requested this change because they need help in the cataloguing process to follow its their procedures manual. If you dont want to execute updatedatabase.pl, simply execute this statement in you database ALTER TABLE `marc_subfield_structure` ADD `punctuation` VARCHAR( 5 ) NULL , ADD `help` VARCHAR( 255 ) NULL;
Created attachment 4632 [details] [review] Patch to 3.4 version Patch to 3.4 version
Looks like this hould be "needs signoff"?
Patch application failed: Applying: Show local help and isbd punctuation when we are cataloguing. /home/liz/kohaclone/.git/rebase-apply/patch:22: trailing whitespace. "SELECT tagfield,tagsubfield,liblibrarian,libopac,tab,mandatory,repeatable,authorised_value,authtypecode,value_builder,kohafield,seealso,hidden,isurl,link,defaultvalue,punctuation,help /home/liz/kohaclone/.git/rebase-apply/patch:191: trailing whitespace. background-color: #F0FFEF; error: patch failed: admin/marc_subfields_structure.pl:425 error: admin/marc_subfields_structure.pl: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:4259 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css:133 error: koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js:89 error: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js: patch does not apply error: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl: does not exist in index error: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl: does not exist in index Patch failed at 0001 Show local help and isbd punctuation when we are cataloguing.
Created attachment 7536 [details] [review] Patch updated to master branch
Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Failed to merge in the changes.
Created attachment 10404 [details] [review] Patch to apply in current master Patch ready to apply in current master
Wanted to sign off, but it does not apply, sorry. Marc
Created attachment 14354 [details] [review] Bug 6138 - Show local help and isbd punctuation automatically when we are cataloguing
I can see and edit the fields in teh framework. However when I try to edit a biblio record, help is not displayed. How I tested: 1) Go to administration->MARC Bibliographic framework->Marc Structure->Subfields->Edit subfields 2) Edit a subfield. Hit "Display more constraints" at the bottom of the screen. 3) Locate two new fields "Punctuation:" and "Help:" under "Advanced Constraints" 4) Put some values in both fields. 5) Save changes 6) Go to catalogiing->Add MARC Record, choose the framework you just used and go to the field where you added help 7) See a link "Show help" at the right of the field. 8) Hit the link. It is something like http://[YORSERVER]/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=#help_tag_942_subfield_n_175538_230054 9) Nothing happens. Result: Error in console: ReferenceError:fields_in_use is not defined. This error appears already when loading the page. It does not appear when I switch back to branch master. Same result while editng an existing biblio record. The HTML page source code where the error happens is as follows: ------------ <input type="text" id="tag_010_subfield_z_283956_276743" name="tag_010_subfield_z_283956_276743" value="" tabindex="1" punctuation="" size="67" maxlength="9999" class="input_marceditor" onfocus="javascript:GetPunctuation(this);" onblur="javascript:CheckPunctuation(this);" /> ------------
- Is this bug still valid? - Patch does not apply
Abandoned dev for specific library, reopen if you want to revisit.