Bug 6138 - Show local help and isbd punctuation automatically when we are cataloguing
Summary: Show local help and isbd punctuation automatically when we are cataloguing
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement with 1 vote (vote)
Assignee: Juan Romay Sieira
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 09:25 UTC by Juan Romay Sieira
Modified: 2020-01-24 19:00 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (14.05 KB, patch)
2011-04-08 09:25 UTC, Juan Romay Sieira
Details | Diff | Splinter Review
Patch to 3.4 version (17.48 KB, patch)
2011-07-14 18:22 UTC, Juan Romay Sieira
Details | Diff | Splinter Review
Patch updated to master branch (15.55 KB, patch)
2012-02-09 16:48 UTC, Juan Romay Sieira
Details | Diff | Splinter Review
Patch to apply in current master (13.84 KB, patch)
2012-06-21 10:05 UTC, Juan Romay Sieira
Details | Diff | Splinter Review
Bug 6138 - Show local help and isbd punctuation automatically when we are cataloguing (14.34 KB, patch)
2013-01-01 23:51 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Juan Romay Sieira 2011-04-08 09:25:20 UTC Comment hidden (obsolete)
Comment 1 Juan Romay Sieira 2011-07-14 18:22:02 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2012-01-19 17:09:30 UTC
Looks like this hould be "needs signoff"?
Comment 3 Liz Rea 2012-02-07 16:20:58 UTC
Patch application failed:


Applying: Show local help and isbd punctuation when we are cataloguing.
/home/liz/kohaclone/.git/rebase-apply/patch:22: trailing whitespace.
        "SELECT tagfield,tagsubfield,liblibrarian,libopac,tab,mandatory,repeatable,authorised_value,authtypecode,value_builder,kohafield,seealso,hidden,isurl,link,defaultvalue,punctuation,help 
/home/liz/kohaclone/.git/rebase-apply/patch:191: trailing whitespace.
	background-color: #F0FFEF; 
error: patch failed: admin/marc_subfields_structure.pl:425
error: admin/marc_subfields_structure.pl: patch does not apply
error: patch failed: installer/data/mysql/updatedatabase.pl:4259
error: installer/data/mysql/updatedatabase.pl: patch does not apply
error: patch failed: koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css:133
error: koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css: patch does not apply
error: patch failed: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js:89
error: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js: patch does not apply
error: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl: does not exist in index
error: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl: does not exist in index
Patch failed at 0001 Show local help and isbd punctuation when we are cataloguing.
Comment 4 Juan Romay Sieira 2012-02-09 16:48:26 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2012-03-03 07:49:13 UTC
Falling back to patching base and 3-way merge...
Auto-merging C4/Biblio.pm
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
Failed to merge in the changes.
Comment 6 Juan Romay Sieira 2012-06-21 10:05:46 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2012-06-28 21:23:00 UTC
Wanted to sign off, but it does not apply, sorry.

Marc
Comment 8 Chris Cormack 2013-01-01 23:51:05 UTC
Created attachment 14354 [details] [review]
Bug 6138 - Show local help and isbd punctuation automatically when we are cataloguing
Comment 9 Marc Véron 2013-01-02 07:37:13 UTC
I can see and edit the fields in teh framework. However when I try to edit a biblio record,  help is not displayed.

How I tested:

1) Go to administration->MARC Bibliographic framework->Marc Structure->Subfields->Edit subfields
2) Edit a subfield. Hit "Display more constraints" at the bottom of the screen.
3) Locate two new fields "Punctuation:" and "Help:" under "Advanced Constraints"
4) Put some values in both fields.
5) Save changes
6) Go to catalogiing->Add MARC Record, choose the framework you just used and go to the field where you added help
7) See a link "Show help" at the right of the field.
8) Hit the link. It is something like http://[YORSERVER]/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=#help_tag_942_subfield_n_175538_230054
9) Nothing happens. 

Result: Error in console: 
ReferenceError:fields_in_use is not defined. 

This error appears already when loading the page. It does not appear when I switch back to branch master.

Same result while editng an existing biblio record.

The HTML page source code where the error happens is as follows:
------------
<input type="text"
		id="tag_010_subfield_z_283956_276743"
		name="tag_010_subfield_z_283956_276743"
		value=""
		tabindex="1"
		punctuation=""
		size="67"
		maxlength="9999"
		class="input_marceditor"
		onfocus="javascript:GetPunctuation(this);"
		onblur="javascript:CheckPunctuation(this);"
/>
------------
Comment 10 Marc Véron 2016-08-23 07:44:57 UTC
- Is this bug still valid?
- Patch does not apply
Comment 11 Liz Rea 2019-04-10 15:18:01 UTC
Abandoned dev for specific library, reopen if you want to revisit.