For example, create an item with call number SHS-PERC'ESP
Created attachment 3831 [details] [review]
Fix automatic incrementation if prefix contains ' and also fix incrementation if it is the first number with this prefix
To test, you should have a framework with callnumber field connected to callnumber.pl plugin
Then you try to create an item on a biblio with this framework. In field callnumber you enter the prefix and then click on ...
Without the patch if your prefix contains a ' (like SHS-PERC'ESP for example), this does nothing. With the patch, callnumber is automatically updated with te next value corresponding (SHS-PERC'ESP 549 for example)
If you enter a new prefix (never used before) without the patch, callnumber is cleared. With the patch it returns the first callnumber for this prefix (WXZ 1 for example)
Created attachment 4928 [details] [review]
proposed patch (passed QA)
* small patch
* good explanations to reproduce the problem and the fixed behaviour
passed QA earned easily.
Just one note:
- return => $code,
+ return => $code
=> this change was useless, it's perfectly valid to have something like
$template->param (xxx => xxx,); in Perl (with a trailing comma at the end)
But is not wrong to have none, so won't refuse passed QA just for this ;-)
Pushed, please test
There have been no further reports of problems so I am marking this bug resolved.