Bug 6256 - Many bib1 attributes missing
Summary: Many bib1 attributes missing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 6499
  Show dependency treegraph
 
Reported: 2011-04-23 16:26 UTC by Jared Camins-Esakov
Modified: 2012-10-25 23:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (4.11 KB, patch)
2011-08-28 01:27 UTC, Ian Walls
Details | Diff | Splinter Review
Follow up patch (891 bytes, patch)
2011-09-07 12:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2011-04-23 16:26:21 UTC
The Zebra configuration for Koha is missing many bib1 attributes. Even if they are not all used, they should all be listed in the bib1.att configuration file. The following attributes are missing:

SICI	1037
Abstract-language	1038
Application-kind	1039
Classification	1040
Classification-basic	1041
Classification-local-record	1042
Enzyme	1043
Possessing-institution	1044
Record-status	1046
Treatment	1047
Control-number-GKD	1048
Control-number-linking	1049
Control-number-PND	1050
Control-number-SWD	1051
Control-number-ZDB	1052
Country-publication (country of Publication)	1053
Date-conference (meeting date)	1054
Date-record-status	1055
Dissertation-information	1056
Meeting-organizer	1057
Note-availability	1058
Number-CAS-registry (CAS registry number)	1059
Number-document (document number)	1060
Number-local-accounting	1061
Number-local-acquisition	1062
Number-local-call-copy-specific	1063
Number-of-reference (reference count)	1064
Number-norm	1065
Number-volume	1066
Place-conference (meeting location)	1067
Reference (references and footnotes)	1068
Referenced-journal (reference work)	1069
Section-code	1070
Section-heading	1071
Subject-GOO	1072
Subject-name-conference	1073
Subject-name-corporate	1074
Subject-genre/form (Formerly "Subject-name-form" renamed August 2003)	1075
Subject-name-geographical	1076
Subject--chronological (formerly "Subject-name-chronological" renamed August 2003)	 1077
Subject--title (formerly "Subject-name-title" renamed August 2003)	1078
Subject--topical (formerly "Subject-name-topical" renamed August 2003)	1079
Subject-uncontrolled	1080
Terminology-chemical (chemical name)	1081
Title-translated	1082
Year-of-beginning	1083
Year-of-ending	1084
Subject-AGROVOC	1085
Subject-COMPASS	1086
Subject-EPT	1087
Subject-NAL	1088
Classification-BCM	1089
Classification-DB	1090
Identifier-ISRC	1091
Identifier-ISMN	1092
Identifier-ISRN	1093
Identifier-DOI	1094
Code-language-original	1095
Title-later 1096
Performer	1185
Performer-Individual	1186
Performer-Group	1187
Instrumentation	1188
Instrumentation-Original	1189
Instrumentation-Current	1190
Arrangement	1191
Arrangement-Original	1192
Arrangement-Current	1193
Musical Key-Original	1194
Musical Key-Current	1195
Date-Composition	1196
Date-Recording	1197
Place-Recording	1198
Country-Recording	1199
Number-ISWC	1200
Number-Matrix	1201
Number-Plate	1202
Classification-McColvin	1203
Duration	1204
Number-Copies	1205
Musical Theme	1206
Instruments - total number	1207
Instruments - distinct number	1208
Identifier - URN	1209
Sears Subject Heading	1210
OCLC Number	1211
Composition	1212
Intellectual level	1213
EAN	1214
NLC	1215
CRCS	1216
Nationality	1217
Equinox	1218
Compression	1219
Format	1220
Subject - occupation	1221
Subject - function	1222
Edition	1223
GPO Item Number 1224	

This list does not include Dublin Core or GILS attributes.
Comment 1 Ian Walls 2011-08-28 01:27:07 UTC
Created attachment 5181 [details] [review]
Proposed Patch

This patch adds the bib1 attributes as defined in the bug report.  Attributes are added in numerical order.  Names are normalized as follows:

Whitespace => '-'
Multiple '-' => single '-'
parenthetical statements dropped

In the case of 1062, it is renamed from "stocknumber" to "Number-local-acquisition".  This should not effect search, but please verify.
Comment 2 Chris Cormack 2011-09-07 08:54:08 UTC
Pushed, please test
Comment 3 Marcel de Rooy 2011-09-07 12:38:10 UTC
Created attachment 5336 [details] [review]
Follow up patch

Fixing small typo in bib1.att
Comment 4 Marcel de Rooy 2011-09-07 12:40:43 UTC
Setting status back to Signed for the follow-up.
Comment 5 Ian Walls 2011-09-07 13:09:45 UTC
Thanks for catching that!  Marking followup as Passed QA, since it implements the correct name following the same conventions used in the original patch
Comment 6 Chris Cormack 2011-09-08 01:49:50 UTC
Follow up pushed, nice catch Marcel
Comment 7 Chris Nighswonger 2011-10-26 18:02:17 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.