uploading the circ overdues result in a csv with columns in a strange order
and not the order of the screen
This patch reorder the column by putting the usefull ones first
Created attachment 4021 [details] [review]
Created attachment 4482 [details] [review]
Before applying the patch, :8080/cgi-bin/koha/circ/overdue.pl?op=csv produced a CSV file with the columns in alphabetical order by column name.
After applying the patch the same URL produces a CSV file with the columns in the order specified in the patch, which does look better.
It's a trivial (2 lines) patch, that is usefull for overdues readability. Marking passed QA even it i'm the author, I think it's not worth having 4 eyes validating : Me, Magnus, and Chris (when merging) is enough for a so small patch
The proposal for QA was
"a) he would not mark any patch he himself has written as Passed QA
b) any patch written by BibLibre would need a signoff from another, external person before he'd test it
c) he would start with the patches that have been waiting the longest
d) the QAM and RM could reject any "Passed QA" patch if they feel it's not sufficient for whatever reason (which would need to be noted in the bug report)"
So even though this is a trivial patch like you say, I would like us to follow the rules we made for ourselves.
Ian can you take a look at this too please.
2 months later, ian has'nt QAed this one line patch.
I mark again as "passed QA", chris you can object again, but in this case, please bug ian ;-)
Still waiting QA from Ian
explicitly-defined keys are consistent with data exported. The order is much more useful than alphabetical. Marking as Passed QA.
Pushed, please test