There is a 1/3 month frequency but not 1/4 month.
Created attachment 4054 [details] [review]
This bug is present also in 3.2.x
(In reply to comment #1)
> Created attachment 4054 [details] [review]
> Proposed patch
1/4 month (3/year)
1/4 months (3/year)
Created attachment 4101 [details] [review]
Patch with typo fix
(In reply to comment #3)
> (In reply to comment #1)
> > Created attachment 4054 [details] [review]
> > Proposed patch
> 1/4 month (3/year)
> must be
> 1/4 months (3/year)
Thanks Stefano. Could you sign-off this patch? (Or Colin?)
Sent signoff for amended patch
Created attachment 4492 [details] [review]
Amended signed-off patch
The subscription Add & serials management seems to work well, BUT the subscription-detail page and the opac misses something.
The display is 3/week instead of 1/4 month on subscription-detail
The current subscription began on 08/01/2010 and is issued every for 24 months
every <<missing periodicity>> for 24 months on OPAC
Created attachment 5444 [details] [review]
Fix error found by Paul.
Anyone available to sign-off this patch? It still applies on HEAD.
Created attachment 5830 [details]
I have tested the subscription pattern and there seems to be a little bit of information missing on the brief history view of opac:
The current subscription began on 01/01/2011 and is issued every _____ for 9 issues.
Created attachment 5834 [details] [review]
Amended proposed patch, with Katrin feedback
With a fix to your OPAC display issue, thanks Katrin.
Created attachment 5835 [details] [review]
[SIGNED-OFF] Bug 6321 Add a 1/4 months frequency
Thanks Stefano Bargioni for the typo fix
[2011.09.16] Thanks Paul for catching the display error.
[2011.10.11] Thanks Katrin for finding display error on OPAC.
Signed-off-by: Colin Campbell <firstname.lastname@example.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.email@example.com>
Tested prediction pattern and display in OPAC.
No problems found.
Updating version : This ENH could be in Koha 3.8
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
The code for making the distinction between the various frequencies is actually asking for some refactoring. This patch just adds another case, but is easy to read and tested thoroughly, as can be seen above.
Marking it as Passed QA.
Patch pushed, please test