When you view a staged record, even if you're adding items, the items don't show up because they're no longer included in the bib record's marc. They should be added in for display purposes.
This bug is still valid in master as of 3.12 beta1.
Created attachment 37310 [details] [review] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them.
Created attachment 37311 [details] [review] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them.
Created attachment 37344 [details] [review] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) OK C4/ImportBatch.pm OK critic OK forbidden patterns OK pod OK valid OK catalogue/showmarc.pl OK critic OK forbidden patterns OK pod OK valid
I found t/db_dependent/ImportBatch.t, but it only includes 5 tests. Maybe they could be a starting point? I am a bit worried by the mismatch of the MARC view with the new diff view. Could we also include the item information in the new diff view? Please read 'Failed QA' as 'Asking for feedback' - tests looking ok so far :)
Created attachment 37540 [details] [review] Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view.
Created attachment 37544 [details] [review] Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio
Created attachment 37552 [details] [review] [PASSED QA] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 37553 [details] [review] [PASSED QA] Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 37554 [details] [review] [PASSED QA] Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.6