This option is intended to stop users with fines from using opac to renew their books. Because the global variable patron_flagged is mistakenly taken to be a variable within larger structures in a couple of places the restriction is never applied. The opac display is also affected (a bogus table column is added and an empty message box is displayed)
Fixing the above logic reveals two further bugs to address:
The Renew Selected button is displayed even although you cannot select any for renewal.
The option cannot be turned off. When editing the syspref it says 'leave blank to disable' as that is read in the script as the value 0.00 it disables renewing for all borrowers with fines. It needs to be set to high value to allow (relatively) unrestricted opac renewals
Created attachment 4657 [details] [review]
Actually it fixed another bug as well which was that the columns were mislabeled if you have the barcode and the 'links' column appearing. I have signed off on this patch!
Easily tested, works well, pushing. Please test and mark resolved
I think this bug is back ...
Patron was allowed to renew at home with late items. Our system setting is set
to no renew if more than .01.
The patron was at home and used IE. She told staff the it said it would not
renew because of fine, but then when she hit OK it renewed. That's all the info
I tested in FF7 on Mac and it prevents renewals, so I think it's a browser compatibility issue.
Created attachment 5842 [details] [review]
This patch standardizes the condition under which renewal controls
are displayed at the page (as opposed to item) level. In some
places "canrenew" was used, in others "patron_flagged" was used.
Now "canrenew" controls renew controls and "patron_flagged" only
triggers the display of user warnings.
This patch also allows for renewal information to be displayed
for each item in situations where OPAC renewals are allowed but
disabled for whatever reason. This gives the patron information
about used/available renew counts but hides renew controls.
Created attachment 6179 [details] [review]
Patch does not apply anymore. Automerge still works, but result needs some editing since a few warnings have been added in the meantime..
Please send a new version; leave the status at Signed Off.
changed to "does not apply", once you've submitted an updated bug, switch back to signed-off, no problem with that
Created attachment 7204 [details] [review]
QA Comment: Looks good (without testing it). Well documented change, improving code. Marking as Passed QA.
Sorry, I wanted to test before pushing, and could not understand which test data I must have to see how the fix works.
Please give a full test plan and switch back to passed QA to reach me directly.
Created attachment 7619 [details]
Screenshot showing view without the patch
Before this patch the user logged in to the OPAC is correctly told that they cannot renew items online because of their fine, but renewal-related controls are displayed (renew selected, renew all).
Created attachment 7620 [details]
Screenshot showing view after the patch
After the patch renewal controls are no longer displayed.
This fix was included in the 3.6.x branch prior to 3.6.4.