Bug 6613 - csv basket export columns misaligned
Summary: csv basket export columns misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Target Milestone: ---
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 14:04 UTC by Nicole C. Engard
Modified: 2012-10-25 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
wrong basket export (460 bytes, text/csv)
2011-07-20 14:04 UTC, Nicole C. Engard
Details
patch (2.89 KB, patch)
2011-07-20 17:15 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-07-20 14:04:27 UTC
Created attachment 4676 [details]
wrong basket export

When you export a basket the columns are not lined up.  The author is under isbn, the title under author, and so on.
Comment 1 Nicole C. Engard 2011-07-20 17:15:26 UTC
Created attachment 4680 [details] [review]
patch
Comment 2 Ian Walls 2011-07-20 17:18:46 UTC
I'm pushing this past QA, but would GREATLY appreciate a third (or fourth) set of eyes, since this does change a C4 subroutine.  If anyone has any discomfort with me being both author and QAM on this patch, please test and verify/signoff or report issues.
Comment 3 Chris Cormack 2011-07-20 21:57:18 UTC
Im happy with these changes, and they seem to work fine. Please test
Comment 4 Katrin Fischer 2011-11-02 21:44:00 UTC
Tested on current master/3.6. All columns align with the correct data in my tests.