Bug 6824 - Basket permissions not looked up correctly
Summary: Basket permissions not looked up correctly
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Robin Sheat
QA Contact: Bugs List
: 6575 (view as bug list)
Depends on: 6390
  Show dependency treegraph
Reported: 2011-08-31 03:08 UTC by Robin Sheat
Modified: 2012-10-25 23:09 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Bug 6824 - correctly check basket viewing permissions (1.85 KB, patch)
2011-08-31 03:28 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 6824 - signed off patch: correctly check basket viewing permissions (1.95 KB, patch)
2011-09-21 21:12 UTC, Melia Meggs
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2011-08-31 03:08:52 UTC
Viewing vendors in the acquisitions system only shows your own baskets unless you are a superlibrarian. This is because it's looking up the permissions incorrectly.
Comment 1 Robin Sheat 2011-08-31 03:28:20 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2011-09-07 06:40:38 UTC
*** Bug 6575 has been marked as a duplicate of this bug. ***
Comment 3 Nicole C. Engard 2011-09-07 15:39:35 UTC
I'm liking the way this is addressed here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 allowing the librarian to decide who can see what.
Comment 4 Robin Sheat 2011-09-11 23:41:07 UTC
I'm thinking that a very quick fix like this can get in to a release smoothly and stop bothering people, then it's pretty easy to make it optional (or, perhaps, do a more comprehensive permissions thing) as a later step.
Comment 5 Melia Meggs 2011-09-21 21:12:12 UTC
Created attachment 5524 [details] [review]
Bug 6824 - signed off patch: correctly check basket viewing permissions

Signed off patch
Comment 6 Ian Walls 2011-09-22 13:45:15 UTC
Easy change to read, marking as Passed QA
Comment 7 Chris Cormack 2011-09-23 01:47:03 UTC
Pushed, please test
Comment 8 Katrin Fischer 2011-10-30 23:50:51 UTC
6390 is now in master and changes the behaviour of this page to be controlled by a syspref. Superlibrarian always sees all baskets.