Viewing vendors in the acquisitions system only shows your own baskets unless you are a superlibrarian. This is because it's looking up the permissions incorrectly.
Created attachment 5234 [details] [review]
Bug 6824 - correctly check basket viewing permissions
Previously you couldn't view baskets that you hadn't created, unless you
were superlibrarian due to a bug. Now people with the right permissions
can see the baskets.
Applies to both 3.04.04 and master.
*** Bug 6575 has been marked as a duplicate of this bug. ***
I'm liking the way this is addressed here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 allowing the librarian to decide who can see what.
I'm thinking that a very quick fix like this can get in to a release smoothly and stop bothering people, then it's pretty easy to make it optional (or, perhaps, do a more comprehensive permissions thing) as a later step.
Created attachment 5524 [details] [review]
Bug 6824 - signed off patch: correctly check basket viewing permissions
Signed off patch
Easy change to read, marking as Passed QA
Pushed, please test
6390 is now in master and changes the behaviour of this page to be controlled by a syspref. Superlibrarian always sees all baskets.