When doing a Z search if you click on a row it highlights in yellow. If you click a preview link that yellow highlight goes away making it hard to figure out which line you were viewing. In 3.4 this highlighting used to stick even after you clicked the preview link.
[12:10] <oleonard> nengard: Do you have an example of that working the way you expect?
[12:10] <oleonard> I agree that the way you describe it is how it *should* work.
[12:11] <nengard> i have to admit I didn't remember it ever working that way, but a partner of ours said it did and I took his word for it
On line 23 of the cataloguing/z3950_search.tt, in the function closemenu(), the selection highlighting is turned off as part of the closing of the menu. This may relate to the fix for 6367; the persistence of the highlighting could have been an unintentional benefit of the misplaced menu ID grabbing.
Created attachment 5698 [details] [review]
Moves the "addClass" call up to right after the row is defined in the JS, so the highlighting of the row will persist after using the popup menu.
Created attachment 5700 [details] [review]
[SIGNED-OFF] Bug 6924: z39.50 results highlighting not sticking
Moves the highlighting call of the JS up to right after 'row' is defined, so the
highlighting will stick even after you click on of the popup menu options
Signed-off-by: Nicole C. Engard <email@example.com>
Question to the community: should this count as a new feature (and thus wait until after 3.6 is released), or as a bugfix for integration immediately? I do not feel qualified to answer, as this patch was a request by a ByWater partner, and it would be in my own self interest for it to be committed soon.
It's a tiny change to a template. No reason not to include it now.
I think it's not a new feature but a small improvement to make things easier. +1 for inclusion.
Given the tiny nature of this patch (moved 1 line), and it's benefit (without introducing new strings), I'm marking this as Passed QA. Integration into 3.6 is of course at the RM's discretion.
With the +1 from one of the translators and sign off from QA, I'm happy to push this, please test.
There have been no further reports of problems so I am marking this bug resolved.