When you send a cart and the person attempts to reply to it, the email goes to the library admin address. This will add a syspref that allows a Reply-To header to be set that will be set to the user of the cart, if they're logged in and have an email address set. Which email address is used will be determined by the AutoEmailPrimaryAddress preference.
Created attachment 5710 [details] [review] Bug 6973 - allow cart and list email to set a reply-to address This adds a syspref (OpacSendReplyTo) that allows the emails sent from carts and lists to have a reply-to address of the sending user (if they're logged in.)
There is going to be a part-two of this that causes these emails to run through the standard message queue system.
Created attachment 5711 [details] [review] Bug 6973 - allow cart and list email to set a reply-to address This adds a syspref (OpacSendReplyTo) that allows the emails sent from carts and lists to have a reply-to address of the sending user (if they're logged in.) (Fixes an error in the previous version)
Total nitpicky thing here .. Why not change the preference so that it doesn't have a 'warning' Use (Sender's Email|Library Admin Address) as the reply to address when sending carts and lists. Instead of a Do/Don't kind of thing. Nicole
That's a good idea!
Created attachment 5724 [details] [review] Bug 6973 - allow cart and list email to set a reply-to address This adds a syspref (OpacSendReplyTo) that allows the emails sent from carts and lists to have a reply-to address of the sending user (if they're logged in.) (Changes the preference description from the previous version)
Still working on a followup patch that cleans up the cart and list sending code.
Created attachment 5728 [details] [review] Bug 6973 - allow cart and list email to set a reply-to address This adds a syspref (OpacSendReplyTo) that allows the emails sent from carts and lists to have a reply-to address of the sending user (if they're logged in.) (Changes the preference description from the previous version)
Comment on attachment 5728 [details] [review] Bug 6973 - allow cart and list email to set a reply-to address Whoops, that attachment was the wrong patch.
Created attachment 5729 [details] [review] Bug 6973 - have list and cart sending go via message_queue This forces the emailing of lists and carts to be placed in the message queue, rather than sent directly from the script. This allows improved centralised configuration and control of the email system. Note that an effect of this is that rather than going out immediately, emails from OPAC users sending carts will only get sent when the process_message_queue script runs. (this is intended to apply on top of the other bug 6973 patch)
Created attachment 5870 [details] [review] Bug 6973 - this forces alerts to use the message queue Alerts, such as serials claims and routing lists messages and new member details originally used sendmail directly. Now they go into the message queue so that they can use centralised configuration.
I asked Robin how the patches work together: First patch is standalone, the others go on top of it.
Hi Robin, does this also affect the 'New Account' message you can send out when creating new accounts? Because this contains the password it should probably not go into the message_queue table.
It does affect the new account message, and you're right, it shouldn't. I'll look into that when I get the chance.
Updating Version : This ENH will be for Koha 3.8
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Robin, I removed the 'needs signoff' for the known problem with the new accounts message. Hope that's ok.
Reading my own comments again, I tried to applying and testing the first patch: 1) Fixed a conflict in sysprefs.sql 2) Did the database update System preference is there and defaults correctly to "library admin mail" 3) List I picked a list and clicked on "Send list" (http://localhost/cgi-bin/koha/opac-sendshelf.pl?shelfid=1). I get a perl error: Global symbol "$user" requires explicit package name at /home/katrin/kohaclone/opac/opac-sendshelf.pl line 60. Execution of /home/katrin/kohaclone/opac/opac-sendshelf.pl aborted due to compilation errors. 4) Cart Works. 5) Changed the system preference to "sender's email". 6) List Same perl error: Global symbol "$user" requires explicit package name at /home/katrin/kohaclone/opac/opac-sendshelf.pl line 60. Execution of /home/katrin/kohaclone/opac/opac-sendshelf.pl aborted due to compilation errors. 7) Cart Works.
Robin, is there a chance you can look at this again? I think it would be a nice improvment.
Robin, any chance of a rebase for these patches?
This enhancement has been dead so long I'm going to reset it to NEW.
*** Bug 13260 has been marked as a duplicate of this bug. ***
Bug 3280 appears to have done the reply-to side of this already...
Looks like the changes to using the message queue instead of direct send are still valid.