my $tablename and my $hash are globally defined in C4::SQLHelper, but are never used; all subroutines use a locally scoped $tablename, and $hash is never used, locally or otherwise.
Removing these two lines may help ensure mod_perl compatibility (since variables in subroutines cannot safely alter values in outer script in persistent environments). Or not. If nothing else, it's just a bit a trivial cleanup.
Created attachment 5970 [details] [review]
Removes two unused global variables from SQLHelper
idea was to use the hash to store the whole database structure and use that rather than making a SHOW TABLE never been implemented because of time.
It should help to store the database structure somewhere in some way.
Would it be DBIC schema, or a yaml file no preference. But should be in our mind though
Created attachment 5997 [details] [review]
[SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper
Removes $tablename and $hash from global scope of C4/SQLHelper.pm. They are never used;
all instances of $table are locally scoped to the subroutines, and $hash is never used.
This may help with persistance; if not, it's at least a bit of trivial cleanup.
1. Search for a patron
2. Create a Contract in Acquisitions
3. Modify that Contract
4. Delete that Contract
All instances should return error free. This checks the subroutines of SQLHelper
Signed-off-by: Nicole C. Engard <firstname.lastname@example.org>
Marking Passed QA, RM please verify.
patch pushed, trivial changes & perfect test plan, please test & close
This was included in the 3.6 branch prior to 3.6.4.