Similar to opac-detail. Facilitates page text search
Created attachment 6145 [details] [review]
Created attachment 6146 [details] [review]
Created attachment 6441 [details]
Print screen 1
Created attachment 6442 [details]
Print screen 2
Thanks for sending your patches, but the description of this bug report is minimal and test plan is missing. It would be helpful to include more information. This will help people testing and signing off as well as QA.
Please look at the two print screens I attached (with and without your patch). With your patch two item type descriptions are listed. This probably occurs when a icon is not found and the alternate text is displayed.
It is a fairly small change so I did not describe it in too many details:
OPAC catalog search results screen have item type displayed as text as well as the icon. This is for the reason being able to use browser text search on the item type. We wanted to replicate that behaviour on the intranet interface, in catalog search and biblio details screens.
How to test:
Check that item type text is displayed at the end of item type description on catalogue/search.pl results screen and catalogue/detail.pl items.
Doubled description is due to the missing icon. You can try searching on "Books", missing icons text should be skipped. If it is not, please check the page source.
Thanks for responding and providing more info.
You are right about the double itemtype. It is not related to your patch; it is just a strange thing on several places in Koha to show it twice if noItemTypeImages is set or the imageurl is empty. In my opinion listing it twice is just a bug. But that is another bug report.
I would like to add to your comment that results depend on the value of pref item-level_itypes. I have two points on your patch now:
if item-level_itypes==item, then the itemtype (+icon) is already in the column Location (per item)
if item-level_itypes==biblio, then the itemtype (+icon) is already in the column Results
my conclusion would be: itemtype is not needed additionally here (redundant)
Catalogue Details/Items tab:
if item-level_itypes==biblio, then the item type is listed with the biblio on top
if item-level_itypes==item, then the item type is listed per item
Your patch apparently does not really change anything here. (But it would catch the situation mentioned above!) It merely rearranges the tests on noItemTypeImages and imageurl.
Looking further, I think that the moredetail script (for the Items tab) should fill imageurl for items, but it does not. The template uses that empty variable! So it never shows an icon. If you change the code here, please resolve that bug too.
After those two points, I am wondering if the changes in Search.pm are necessary. Did not further look into that. Could you explain why they are necessary?
I agree with you that this is a lot of text for a small patch ;)
Sorry for the confusion. I was looking for catalogue/detail items at catalogue moredetail items.
The noItemTypeImages variable is already filled in Auth.pm, so that is not a bug. Moredetail simply never shows the icon.
Your patch adds the description at detail, so that is okay.
Remains the first point of search results and the question whether changes in Search.pm are needed?
So, even more text.. :-)
Search Results: I cannot see where the item type description gets duplicated. My intention was only to make sure it gets displayed regardless of whether the icon is present or not. Can you please point out/supply a screenshot of duplicated item type descriptions
(In reply to comment #9)
> Search Results: I cannot see where the item type description gets duplicated.
> My intention was only to make sure it gets displayed regardless of whether the
> icon is present or not. Can you please point out/supply a screenshot of
> duplicated item type descriptions
Please see comment 7 (not relevant for this report).
Remains the first point of search results and the question whether changes in
Search.pm are needed?
Created attachment 7344 [details] [review]
Correct, there was a duplication in one case, I've removed it.
Re changes in Search.pm, I believe those are needed, because item type description was not being returned for items, so whenever it was expected on the item level it was empty
Created attachment 7475 [details] [review]
Bug 7140: Added item description to complement icon to search result and biblio detail pages
Signed-off-by: Jared Camins-Esakov <firstname.lastname@example.org>
This seems like a very big improvement, especially for people using screen
readers. I agree that the change to C4::Search is required.
Trying to QA this patch, and there's something I don't understand.
The display of the img is:
<img src="[% itemloo.imageurl %]" alt="[% itemloo.description %]" title="[% itemloo.description %]" />
BEFORE the patch.
isn't alt related to dealing with the case of screen readers, displaying the "alt" instead of the image ?
I tried my test database (that is item-level_itype=biblio), and I see the "Disque compact" text instead of the image when I run lynx.
Our clients asked us for this, so they must have a reason. Do you want me to ask them which particular reader/process they are using?
(In reply to comment #14)
> Our clients asked us for this, so they must have a reason. Do you want me to
> ask them which particular reader/process they are using?
yes, please. And more than this, could you/they confirm that they're not seeing the text twice, because I think they should.
We find having the item type descriptions along with the item type icon in the detail of the Bibl record provides useful information to our clients and staff using the OPAC.
We believe that it would also be useful for staff in he staff client.
As we have numerous item types having unique icons for each item type is impractical, hence the value of the item type description.
Likewise having the item type descriptions along with the item type icon in the client search results would provide staff with useful information without much screen clutter.
Our motivation is not primarily based around alternate browsers or aiding the browsing of visually impaired users, but this is certainly a welcome addition.
Looks good to me. Marking as Passed QA.
Note that display depends on various settings like item-level_itypes, staff xslt options, noitemtypeimages.
If imageurl exists but switches to alternative text display, the description is duplicated (missing icon case): no problem.
This bug will be included in the Koha 3.6.5 release.