Bug 7234 - koha-common Debian package should include koha-sites.conf
Summary: koha-common Debian package should include koha-sites.conf
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Robin Sheat
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 01:38 UTC by Jared Camins-Esakov
Modified: 2017-01-16 05:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7234: koha-common Debian package should include koha-sites.conf (1.60 KB, patch)
2014-02-27 15:44 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 7234: koha-common Debian package should include koha-sites.conf (2.91 KB, patch)
2014-02-28 14:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED OFF] Bug 7234: koha-common Debian package should include koha-sites.conf (2.97 KB, patch)
2014-02-28 15:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 7234: koha-common Debian package should include koha-sites.conf (3.01 KB, patch)
2014-03-02 21:47 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2011-11-16 01:38:51 UTC
The koha-common Debian package should provide a sample koha-sites.conf file, so that people can see what the options are. Even better would be if it's possible to have an interactive mode in the package installer so that it requests the settings it needs (or maybe it could look up domain, etc., from somewhere else on the system?).

This bug may be invalid. Please mark it as such if it is.
Comment 1 Robin Sheat 2011-11-16 02:31:59 UTC
I'm wanting to make it ask debconf questions to populate the initial koha-sites.conf. it's been on my want-to-do list for a while, so definitely not invalid.
Comment 2 Tomás Cohen Arazi 2014-02-27 15:44:57 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-02-27 18:21:33 UTC
I don't think the port should be 8080 for the staff client. We should be doing a name-based install by default, because tweaking the apache file after for production is beyond the scope of Koha. Also, Has Robin made any progress on the idea of a "debconf questions to populate the initial koha-sites.conf" concept?
Comment 4 Robin Sheat 2014-02-27 21:43:20 UTC
Yeah, agreed on the port, it should be name-based (otherwise you have to enable it in ports.conf and such, but also name-based is more better.) Otherwise a good start, though perhaps we should have it with comments after the lines to show what this means and what the other options could be.

It's good to have something until we get around to debconfing it properly. I should probably study the config for something like postfix, that will do the sort of thing that we need.
Comment 5 Tomás Cohen Arazi 2014-02-28 14:07:08 UTC Comment hidden (obsolete)
Comment 6 Mark Tompsett 2014-02-28 15:28:39 UTC Comment hidden (obsolete)
Comment 7 Robin Sheat 2014-03-02 21:47:45 UTC
Created attachment 25750 [details] [review]
Bug 7234: koha-common Debian package should include koha-sites.conf

This patch adds a sample koha-sites.conf file, which will be
included by the koha-common package in /etc/koha (where it belongs).

It is fixed to include the current defaults (DOM indexing for both biblios
and authorities, disabled use of memcached, and good defaults for a normal
setup if enabled).

All options are commented for ease of use by average users.

To test
- verify that the defaults are sane (let me know if it needs to be fixed).
- build the package and verify that the file gets installed.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 8 Robin Sheat 2014-03-02 21:48:42 UTC
I like that, it's good :)
Comment 9 Galen Charlton 2014-03-03 15:58:14 UTC
Pushed to master.  Thanks, Tomás!
Comment 10 Fridolin Somers 2014-05-27 11:02:22 UTC
Pushed to 3.14.x, will be in 3.14.07