Bug 7319 - Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages
Summary: Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
Depends on:
Reported: 2011-12-05 14:36 UTC by Owen Leonard
Modified: 2013-12-05 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed fix (3.13 KB, patch)
2011-12-05 14:48 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7319 - Improving title and breadcrumbs on acquisitions Z39.50 search pages (3.18 KB, patch)
2011-12-06 06:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-12-05 14:36:47 UTC
If you search for an item via Z39.50 search to add to an order the initial search page says "Z39.50 Search Results." The title and breadcrumbs should reflect the correct stage of the operation.
Comment 1 Owen Leonard 2011-12-05 14:48:31 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-12-06 06:25:08 UTC
Created attachment 6590 [details] [review]
[SIGNED-OFF] Bug 7319 - Improving title and breadcrumbs on acquisitions Z39.50 search pages

Changing title and breadcrumbs so that they correctly reflect
the curent stage of the process.

To test: Add to an order from an external source. When filling
out the Z39.50 search form the title and breadcrumbs should read
"Order from external sources." After searching they should read
"Order from external sources -> Search results"

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 3 Paul Poulain 2011-12-15 15:50:33 UTC
QA comment:
Owen, shouldn't
+    <h2>Search results</h2>

be spelled 
+    <h2>Z39.50 Search results</h2>
for an even more relevant title ? (I fear that catalogue "Search result" could be translated in a different way, and be displayed here, resulting in something strange)
Comment 4 Owen Leonard 2011-12-15 16:24:39 UTC
(In reply to comment #3)
> Owen, shouldn't
> +    <h2>Search results</h2>
> be spelled 
> +    <h2>Z39.50 Search results</h2>

A valid question. Here's my reasoning:

- First, the patch changes the heading from "<h2>Results</h2>" to "<h2>Search 
  results</h2>", so it's actually more specific than it was before.
- The link which brings you to this search reads [order] "From an external
  source," so I added the "Order from an external source" terminology to the
  search page itself (in the title and breadcrumbs)
- With that in mind I changed the heading of the search form from "Z39.50
  Search Points" to "Order from external source." At this point there 
  is no reference anywhere to "Z39.50" which would necessitate the use of
  the term on the search results page.

I see that when translating from English the phrase "Search results" could be interpreted as "the results of your search" or "search the results." Is that the problem?
Comment 5 Katrin Fischer 2011-12-16 09:05:44 UTC
I think search results will work for German - it's referring to the reult list of a search not depending on the source of the results. I think a shorter description without repetitions makes is easier to read the breadcrumbs.
Comment 6 Paul Poulain 2011-12-16 09:46:12 UTC
QA comment: OK, katrin, you convinced me. Template change only, 
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok     
prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. ok   

passed QA

patch pushed, please test