Spotted while working on a translation bug, reporting so that it does not get lost: intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: [% IF ( looptable.looprow ) %] [% FOREACH loopro IN looptable.looprow %] [% DEFAULT loopro.itemcallnumber="No Call Number" loopro.barcode="No Barcode" loopro.title="NO TITLE" loopro.author="" %] [% UNLESS ( loop.odd ) %]<tr class="highlight"> [% ELSE %]<tr>[% END %] staff po file: %s %s [%% DEFAULT loopro.itemcallnumber=\"No Call Number\" loopro.barcode=\"No Barcode\" loopro.title=\"NO TITLE\" loopro.author=\"\" %%] %s That will not work if translated like that. It also seems like " are escaped in the po files now, which does not seem right to me. There are other examples, that will break things if copied over with espcaped double quotes.
Created attachment 20238 [details] [review] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt
Created attachment 20601 [details] [review] [SIGNED OFF] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, thx Owen! Applied on top of 10718 for testing.
Created attachment 20701 [details] [review] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, thx Owen! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen!