Bug 7735 - Removal of C4::Dates from acqui/ordered.pl and acqui/spent.pl
Summary: Removal of C4::Dates from acqui/ordered.pl and acqui/spent.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low trivial (vote)
Assignee: Adrien SAURAT
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks: 7444
  Show dependency treegraph
 
Reported: 2012-03-19 13:14 UTC by Adrien SAURAT
Modified: 2013-12-05 20:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch #1 (1013 bytes, patch)
2012-03-19 13:19 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[PASSED QA] Bug 7735: removal of C4::Dates when unused (1.11 KB, patch)
2012-03-20 00:28 UTC, Ian Walls
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-03-19 13:14:50 UTC
Fixes concerning the bug 929 introduced in a few pages the use of a Template Toolkit filter.
Now with a TT update looking like...
[% USE KohaDates %]
[% somevariable | $KohaDates %]
... it's possible to format a date according to the system preferences in an efficient way.

Bug 7444 suggests to use this everywhere on Koha.

--
This bug will simply remove the C4::Dates call in two pages where the filters are now being used (since bug 929), making this call useless (spent.pl and ordered.pl).
Comment 1 Adrien SAURAT 2012-03-19 13:19:23 UTC Comment hidden (obsolete)
Comment 2 Ian Walls 2012-03-20 00:28:58 UTC
Created attachment 8320 [details] [review]
[PASSED QA] Bug 7735: removal of C4::Dates when unused

Removes use of C4::Dates in acqui/ordered.pl and acqui/spent.pl

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Comment 3 Ian Walls 2012-03-20 00:30:09 UTC
Pages are fine without these dependencies; tested by loading both on staff client and command line.
Comment 4 Ian Walls 2012-03-20 00:30:30 UTC
Marking Signed Off and Passed QA in one go.
Comment 5 Jared Camins-Esakov 2012-12-31 00:51:31 UTC
There have been no further reports of problems so I am marking this bug resolved.