It's not possible to add a new z39.50 server in current master. After saving you get a success message, but the server is not added.
The logs show an error:
[Wed Mar 21 12:20:42 2012] [error] [client 127.0.0.1] [Wed Mar 21 12:20:42 2012] z3950servers.pl: DBD::mysql::st execute failed: called with 9 bind variables when 10 are needed at /home/katrin/kohaclone/admin/z3950servers.pl line 115., referer: http://localhost:8080/cgi-bin/koha/admin/z3950servers.pl?op=add_form
Created attachment 8417 [details] [review]
proposed patch #1
Allows creation of a new server
+ "use warnings" now enabled and logs cleaned
Created attachment 8429 [details] [review]
[SIGNED-OFF] Bug 7778: fixes creation of a new server
It is now possible to add a new server
The page also now complies with the bug 2505 request
(use warnings has been added, and variables declarations
corrected to prevent warnings)
Signed-off-by: Katrin Fischer <Katrin.Fischer.firstname.lastname@example.org>
Works perfectly, tested adding, editing and deleting z39.50 servers.
Better handles several default cases, and makes the DB query syntax much easier to read and understand. Good fix, marking as Passed QA.
This patch also improves code quality => great job katrin !
(assigned to 3.6 but not sure the problem exist here: it would be surprising that no-one spotted it before !)
Paul, it was not me, but Adrien :) He fixed it fast and made the code better :)