Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks
Summary: Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Magnus Enger
QA Contact: Ian Walls
URL:
Keywords:
Depends on: 7263
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-29 19:22 UTC by Magnus Enger
Modified: 2013-12-05 19:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks (638.14 KB, patch)
2012-03-30 08:30 UTC, Magnus Enger
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks (638.22 KB, patch)
2012-04-01 18:57 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2012-03-29 19:22:16 UTC
Some subfields of 952 in the NORMARC frameworks have hidden = -1 when they should be 0, resulting in the fields not being displayed correctly in the item edit screen. Gonna fix that!
Comment 1 Magnus Enger 2012-03-30 08:30:35 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-04-01 18:57:14 UTC
Created attachment 8745 [details] [review]
[SIGNED-OFF] Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks

This patch does three things:

- Add a copyright comment to normarc_fastadd_framework.sql
- Change the value of marc_subfield_structure.hidden from -1 to 0 for
  several subfields of 952, in both the default and fast add framework,
  using this SQL statement:
  update marc_subfield_structure set hidden = 0 where tagfield = '952' and hidden = -1;
- Add the maxlength column introduced by bug 7263 to all rows in
  marc_subfield_structure, setting the following maxlengths:
  000 = 24
  008 = 40
  all other subfields = 9999

The format of the SQL files is the one that is produced by exporting the
frameworks from the Web UI, with added copyright comments at the top.

To test:
- Install nb-NO
- Run through the web installer in Norwegian on an empty database
- Select NORMARC as the marcflavour
- Be sure to select the fast add framework ("Rammeverk for
  hurtigkatalogisering" under "Valgritt")
- Check in Home › Administration › MARC Frameworks that 000 and 008
  for both frameworks have the right length
- Add a dummy record so you get to the item edit screen and check that
  the form for subfields looks good. The subfields that are shown
  should be 01234578abcdefghjoptuvwyz and all subfields should have
  a text box or a dropdown associated with them. Check this for
  for both the default and fast add frameworks

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Walked through the test plan, seems to work well.
Comment 3 Ian Walls 2012-04-04 11:04:57 UTC
NORMARC only, and I'll trust the textual content to be correct.  Looks to be safe SQL changes, clear and clean (if a little tedious to read through, thanks to Gits line-by-line basis instead of char-by-char).  Marking as Passed QA.
Comment 4 Magnus Enger 2012-04-27 14:21:04 UTC
Works in 3.8.